drivers/staging/vme/Kconfig:5:warning: type of 'VME' redefined from 'boolean' to 'tristate'

drivers/staging/vme/Kconfig:5:warning: type of 'VME' redefined from 'boolean' to 'tristate'

[Geert Uytterhoeven]

http://kisskb.ellerman.id.au/kisskb/buildresult/1221192/:
drivers/staging/vme/Kconfig:5:warning: type of 'VME' redefined from
'boolean' to 'tristate'
drivers/staging/vme/Kconfig:5:warning: type of 'VME' redefined from
'boolean' to 'tristate'

We already have:

arch/m68k/Kconfig:config VME
arch/m68k/Kconfig:      bool "VME (Motorola and BVM) support"
arch/m68k/Kconfig:        Say Y here if you want to build a kernel for
a 680x0 based VME
arch/m68k/Kconfig:      depends on VME
arch/m68k/Kconfig:        Say Y to include support for early Motorola
VME boards.  This will
arch/m68k/Kconfig:      depends on VME
arch/m68k/Kconfig:        Say Y to include support for Motorola VME
boards.  This will build a
arch/m68k/Kconfig:      depends on VME
arch/m68k/Kconfig:        Say Y to include support for VME boards from
BVM Ltd.  This will
arch/m68k/Kconfig:      depends on (AMIGA || ATARI || MAC || SUN3 ||
SUN3X || VME || APOLLO) && (ATARI_MFPSER=y || ATARI_SCC=y || AT
fs/partitions/Kconfig:  default y if VME

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: drivers/staging/vme/Kconfig:5:warning: type of 'VME' redefined from 'boolean' to 'tristate'

[Greg KH]

On Fri, Sep 11, 2009 at 04:26:36PM +0200, Geert Uytterhoeven wrote:
> http://kisskb.ellerman.id.au/kisskb/buildresult/1221192/:
> drivers/staging/vme/Kconfig:5:warning: type of 'VME' redefined from
> 'boolean' to 'tristate'
> drivers/staging/vme/Kconfig:5:warning: type of 'VME' redefined from
> 'boolean' to 'tristate'
> 
> We already have:
> 
> arch/m68k/Kconfig:config VME
> arch/m68k/Kconfig:      bool "VME (Motorola and BVM) support"
> arch/m68k/Kconfig:        Say Y here if you want to build a kernel for
> a 680x0 based VME

Ah, not good.

Are these a board-specific thing?  It's not the "VME bus" is it?

Martyn, maybe we should rename CONFIG_VME to CONFIG_VME_BUS ?

thanks,

greg k-h

Re: drivers/staging/vme/Kconfig:5:warning: type of 'VME' redefined from 'boolean' to 'tristate'

[Martyn Welch]

Greg KH wrote:
> On Fri, Sep 11, 2009 at 04:26:36PM +0200, Geert Uytterhoeven wrote:
>   
>> http://kisskb.ellerman.id.au/kisskb/buildresult/1221192/:
>> drivers/staging/vme/Kconfig:5:warning: type of 'VME' redefined from
>> 'boolean' to 'tristate'
>> drivers/staging/vme/Kconfig:5:warning: type of 'VME' redefined from
>> 'boolean' to 'tristate'
>>
>> We already have:
>>
>> arch/m68k/Kconfig:config VME
>> arch/m68k/Kconfig:      bool "VME (Motorola and BVM) support"
>> arch/m68k/Kconfig:        Say Y here if you want to build a kernel for
>> a 680x0 based VME
>>     
>
> Ah, not good.
>
> Are these a board-specific thing?  It's not the "VME bus" is it?
>
> Martyn, maybe we should rename CONFIG_VME to CONFIG_VME_BUS ?
>
> thanks,
>
> greg k-h
>   
Agreed - Not good.

I'll try and rustle up a patch ASAP, but it might not be until Monday 
now - I unfortunately have a rather busy weekend. I'm more than happy 
with CONFIG_VME_BUS if someone beats me to it.

Martyn

-- 
Martyn Welch MEng MPhil MIET (Principal Software Engineer)   T:+44(0)1327322748
GE Fanuc Intelligent Platforms Ltd,        |Registered in England and Wales
Tove Valley Business Park, Towcester,      |(3828642) at 100 Barbirolli Square,
Northants, NN12 6PF, UK T:+44(0)1327359444 |Manchester,M2 3AB  VAT:GB 927559189

Re: drivers/staging/vme/Kconfig:5:warning: type of 'VME' redefined from 'boolean' to 'tristate'

[Greg KH]

On Fri, Sep 11, 2009 at 05:29:31PM +0100, Martyn Welch wrote:
> Greg KH wrote:
> > On Fri, Sep 11, 2009 at 04:26:36PM +0200, Geert Uytterhoeven wrote:
> >   
> >> http://kisskb.ellerman.id.au/kisskb/buildresult/1221192/:
> >> drivers/staging/vme/Kconfig:5:warning: type of 'VME' redefined from
> >> 'boolean' to 'tristate'
> >> drivers/staging/vme/Kconfig:5:warning: type of 'VME' redefined from
> >> 'boolean' to 'tristate'
> >>
> >> We already have:
> >>
> >> arch/m68k/Kconfig:config VME
> >> arch/m68k/Kconfig:      bool "VME (Motorola and BVM) support"
> >> arch/m68k/Kconfig:        Say Y here if you want to build a kernel for
> >> a 680x0 based VME
> >>     
> >
> > Ah, not good.
> >
> > Are these a board-specific thing?  It's not the "VME bus" is it?
> >
> > Martyn, maybe we should rename CONFIG_VME to CONFIG_VME_BUS ?
> >
> > thanks,
> >
> > greg k-h
> >   
> Agreed - Not good.
> 
> I'll try and rustle up a patch ASAP, but it might not be until Monday 
> now - I unfortunately have a rather busy weekend. I'm more than happy 
> with CONFIG_VME_BUS if someone beats me to it.

I'll go do it right now.

thanks,

greg k-h

Re: drivers/staging/vme/Kconfig:5:warning: type of 'VME' redefined from 'boolean' to 'tristate'

[Geert Uytterhoeven]

On Fri, Sep 11, 2009 at 17:02, Greg KH<greg@kroah.com> wrote:
> On Fri, Sep 11, 2009 at 04:26:36PM +0200, Geert Uytterhoeven wrote:
>> http://kisskb.ellerman.id.au/kisskb/buildresult/1221192/:
>> drivers/staging/vme/Kconfig:5:warning: type of 'VME' redefined from
>> 'boolean' to 'tristate'
>> drivers/staging/vme/Kconfig:5:warning: type of 'VME' redefined from
>> 'boolean' to 'tristate'
>>
>> We already have:
>>
>> arch/m68k/Kconfig:config VME
>> arch/m68k/Kconfig:      bool "VME (Motorola and BVM) support"
>> arch/m68k/Kconfig:        Say Y here if you want to build a kernel for
>> a 680x0 based VME
>
> Ah, not good.
>
> Are these a board-specific thing?  It's not the "VME bus" is it?

These are to enable support for the original VME-based machines (VME
started it's life on m68k).

From a historical point of view, it's a bit funny to see the new
CONFIG_VME(_BUS) depends on PCI ;-)

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds