From: Andrew Vasquez <andrew.vasquez@qlogic.com>
To: James Bottomley <James.Bottomley@suse.de>
Cc: Linux SCSI Mailing List <linux-scsi@vger.kernel.org>,
Randy Dunlap <randy.dunlap@oracle.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Giridhar Malavali <giridhar.malavali@qlogic.com>,
Ravi Anand <ravi.anand@qlogic.com>,
Lalit Chandivade <lalit.chandivade@qlogic.com>
Subject: [PATCHv2] qla2xxx: Correct compilation issues when CONFIG_MOUDLES=n.
Date: Fri, 11 Sep 2009 17:38:08 -0700 [thread overview]
Message-ID: <20090912003808.GD12098@plap4-2.local> (raw)
In-Reply-To: <20090912001752.GC12098@plap4-2.local>
Randy Dunlap noted:
when CONFIG_MODULES=n:
drivers/scsi/qla2xxx/qla_os.c:2685: error: dereferencing pointer to incomplete type
in
kobject_uevent_env(&(&vha->hw->pdev->driver->driver)->owner->mkobj.kobj,
KOBJ_CHANGE, envp);
Trigger kobject event on the 'struct device' hanging off the pci_dev.
Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
---
> On Fri, 11 Sep 2009, Andrew Vasquez wrote:
>
> > The struct device's kobj from pdev->dev?
> >
> > My udev-foo is pathetic, so how exactly would that get multiplexed at
> > the udev side?
> >
> > KERNEL=="???", SUBSYSTEM=="???", ACTION=="change", RUN+="qla2xxx_udev.sh"
>
> Ok, udevadm helps a bit... Let me see if I can convert this uevent
> off of:
>
> kobject_uevent_env(&(&vha->hw->pdev->dev)->kobj, KOBJ_CHANGE, envp);
>
> to something meaningful:
>
> UEVENT[1252714722.263731] change
> /devices/pci0000:17/0000:17:08.0/0000:1e:00.0 (pci)
> ACTION=change
> DEVPATH=/devices/pci0000:17/0000:17:08.0/0000:1e:00.0
> SUBSYSTEM=pci
> FW_DUMP=6
> DRIVER=qla2xxx
> PHYSDEVBUS=pci
> PHYSDEVDRIVER=qla2xxx
> PCI_CLASS=C0400
> PCI_ID=1077:2532
> PCI_SUBSYS_ID=1077:015C
> PCI_SLOT_NAME=0000:1e:00.0
> MODALIAS=pci:v00001077d00002532sv00001077sd0000015Cbc0Csc04i00
> SEQNUM=3574
Ok, with the kobject_uevent_env() change and the udev-rule modified to:
SUBSYSTEM=="pci", ENV{DRIVER}="qla2xxx", ACTION=="change", RUN+="qla2xxx_udev.sh"
we're working again.
This seem reasonable?
Thanks, AV
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 29396c0..369a270 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -2683,8 +2683,7 @@ qla2x00_uevent_emit(struct scsi_qla_host *vha, u32 code)
/* do nothing */
break;
}
- kobject_uevent_env(&(&vha->hw->pdev->driver->driver)->owner->mkobj.kobj,
- KOBJ_CHANGE, envp);
+ kobject_uevent_env(&(&vha->hw->pdev->dev)->kobj, KOBJ_CHANGE, envp);
}
void
next prev parent reply other threads:[~2009-09-12 0:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-07 11:02 linux-next: Tree for September 7 Stephen Rothwell
2009-09-07 16:49 ` Next Sept 7: Bug : skb_release_head_state on x86 Sachin Sant
[not found] ` <4AA5399A.405@in.ibm.com>
2009-09-07 17:17 ` Eric Dumazet
2009-09-08 5:09 ` Sachin Sant
2009-09-09 11:13 ` Sachin Sant
2009-09-09 12:10 ` Eric Dumazet
2009-09-07 17:27 ` linux-next: Tree for September 7 (scsi/qla2x) Randy Dunlap
2009-09-08 18:25 ` Andrew Vasquez
2009-09-11 17:53 ` qla2xxx: Correct compilation issues when CONFIG_MOUDLES=n (was: Re: linux-next: Tree for September 7 (scsi/qla2x)) Andrew Vasquez
2009-09-11 21:25 ` Randy Dunlap
2009-09-11 22:42 ` James Bottomley
2009-09-12 0:07 ` Andrew Vasquez
2009-09-12 0:17 ` Andrew Vasquez
2009-09-12 0:38 ` Andrew Vasquez [this message]
2009-09-12 0:54 ` [PATCHv2] qla2xxx: Correct compilation issues when CONFIG_MOUDLES=n Greg KH
2009-09-12 2:56 ` Andrew Vasquez
2009-09-12 4:33 ` Greg KH
2009-09-12 14:30 ` James Bottomley
2009-09-15 15:33 ` Greg KH
2009-09-15 15:47 ` James Bottomley
2009-09-15 16:44 ` [PATCHv4] qla2xxx: Add firmware-dump kobject uevent notification Andrew Vasquez
2009-09-15 16:57 ` [PATCHv2] qla2xxx: Correct compilation issues when CONFIG_MOUDLES=n Greg KH
2009-09-15 17:22 ` Kay Sievers
2009-09-15 18:29 ` Greg KH
2009-09-15 21:57 ` Andrew Vasquez
2009-09-15 18:26 ` Andrew Vasquez
2009-09-12 4:06 ` James Bottomley
2009-09-12 16:43 ` [PATCHv3] qla2xxx: Correct compilation issues when CONFIG_MODULES=n Andrew Vasquez
2009-09-13 21:02 ` Randy Dunlap
2009-09-08 0:08 ` [PATCH -next] usb gadget: ether needs to select CRC32 Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090912003808.GD12098@plap4-2.local \
--to=andrew.vasquez@qlogic.com \
--cc=James.Bottomley@suse.de \
--cc=giridhar.malavali@qlogic.com \
--cc=lalit.chandivade@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=ravi.anand@qlogic.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).