From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Vasquez Subject: [PATCHv3] qla2xxx: Correct compilation issues when CONFIG_MODULES=n. Date: Sat, 12 Sep 2009 09:43:56 -0700 Message-ID: <20090912164356.GA19451@plap4-2.local> References: <20090907210206.7830ba68.sfr@canb.auug.org.au> <20090907102747.ac6b98ff.randy.dunlap@oracle.com> <20090908182541.GB44157@plap4-2.local> <20090911175341.GH710@plap4-2.local> <1252708951.13282.151.camel@mulgrave.site> <20090912000742.GB12098@plap4-2.local> <20090912001752.GC12098@plap4-2.local> <20090912003808.GD12098@plap4-2.local> <1252728393.13282.485.camel@mulgrave.site> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1252728393.13282.485.camel@mulgrave.site> Sender: linux-scsi-owner@vger.kernel.org To: James Bottomley Cc: Linux SCSI Mailing List , Randy Dunlap , Stephen Rothwell , "linux-next@vger.kernel.org" , LKML , Giridhar Malavali , Ravi Anand , Lalit Chandivade List-Id: linux-next.vger.kernel.org Randy Dunlap noted: when CONFIG_MODULES=n: drivers/scsi/qla2xxx/qla_os.c:2685: error: dereferencing pointer to incomplete type in kobject_uevent_env(&(&vha->hw->pdev->driver->driver)->owner->mkobj.kobj, KOBJ_CHANGE, envp); Trigger kobject event on the 'struct device' hanging off the pci_dev. Signed-off-by: Andrew Vasquez --- On Fri, 11 Sep 2009, James Bottomley wrote: > > diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c > > index 29396c0..369a270 100644 > > --- a/drivers/scsi/qla2xxx/qla_os.c > > +++ b/drivers/scsi/qla2xxx/qla_os.c > > @@ -2683,8 +2683,7 @@ qla2x00_uevent_emit(struct scsi_qla_host *vha, u32 code) > > /* do nothing */ > > break; > > } > > - kobject_uevent_env(&(&vha->hw->pdev->driver->driver)->owner->mkobj.kobj, > > - KOBJ_CHANGE, envp); > > + kobject_uevent_env(&(&vha->hw->pdev->dev)->kobj, KOBJ_CHANGE, envp); > > Much better. Of course to be perfect, you might like to remember that > (&x)->y is actually x.y > > so > > kobject_uevent_env(&vha->hw->pdev->dev.kobj, ... Ahh, of course... Perfection...the enemy of progress... diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 29396c0..86f337f 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -2683,8 +2683,7 @@ qla2x00_uevent_emit(struct scsi_qla_host *vha, u32 code) /* do nothing */ break; } - kobject_uevent_env(&(&vha->hw->pdev->driver->driver)->owner->mkobj.kobj, - KOBJ_CHANGE, envp); + kobject_uevent_env(&vha->hw->pdev->dev.kobj, KOBJ_CHANGE, envp); } void