[PATCH] edac: need to export cpu_llc_id

[PATCH] edac: need to export cpu_llc_id

[Stephen Rothwell]

Today's linux-next build (x86_64 allmodconfig) failed like this:

ERROR: "per_cpu__cpu_llc_id" [drivers/edac/edac_core.ko] undefined!

Caused by commit b69b29de65fe4078b125acc9dea34be82f7c362c ("EDAC, AMD:
carve out MCi_STATUS decoding").

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/x86/kernel/smpboot.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index a25eeec..04c74b4 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -100,6 +100,7 @@ EXPORT_SYMBOL(smp_num_siblings);
 
 /* Last level cache ID of each logical CPU */
 DEFINE_PER_CPU(u16, cpu_llc_id) = BAD_APICID;
+EXPORT_PER_CPU_SYMBOL(cpu_llc_id);
 
 /* representing HT siblings of each logical CPU */
 DEFINE_PER_CPU(cpumask_var_t, cpu_sibling_map);
-- 
1.6.3.3


-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: [PATCH] edac: need to export cpu_llc_id

[Borislav Petkov]

Hi Stephen,

On Wed, Sep 16, 2009 at 09:39:35AM +1000, Stephen Rothwell wrote:
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> ERROR: "per_cpu__cpu_llc_id" [drivers/edac/edac_core.ko] undefined!
> 
> Caused by commit b69b29de65fe4078b125acc9dea34be82f7c362c ("EDAC, AMD:
> carve out MCi_STATUS decoding").
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  arch/x86/kernel/smpboot.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> index a25eeec..04c74b4 100644
> --- a/arch/x86/kernel/smpboot.c
> +++ b/arch/x86/kernel/smpboot.c
> @@ -100,6 +100,7 @@ EXPORT_SYMBOL(smp_num_siblings);
>  
>  /* Last level cache ID of each logical CPU */
>  DEFINE_PER_CPU(u16, cpu_llc_id) = BAD_APICID;
> +EXPORT_PER_CPU_SYMBOL(cpu_llc_id);
>  
>  /* representing HT siblings of each logical CPU */
>  DEFINE_PER_CPU(cpumask_var_t, cpu_sibling_map);
> -- 
> 1.6.3.3

proper fix is at http://marc.info/?l=linux-kernel&m=125302459621925

we still have to figure out who's gonna pick it up. Ingo?

-- 
Regards/Gruss,
Boris.

Operating | Advanced Micro Devices GmbH
  System  | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany
 Research | Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
  Center  | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
  (OSRC)  | Registergericht München, HRB Nr. 43632

Re: [PATCH] edac: need to export cpu_llc_id

[H. Peter Anvin]

On 09/15/2009 09:41 PM, Borislav Petkov wrote:
> 
> proper fix is at http://marc.info/?l=linux-kernel&m=125302459621925
> 
> we still have to figure out who's gonna pick it up. Ingo?
> 

This was from a tree you pushed straight to Linus, so it's probably
better you push it directly.

You can add:

Acked-by: H. Peter Anvin <hpa@zytor.com>

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

Re: [PATCH] edac: need to export cpu_llc_id

[Borislav Petkov]

On Tue, Sep 15, 2009 at 09:51:47PM -0700, H. Peter Anvin wrote:
> On 09/15/2009 09:41 PM, Borislav Petkov wrote:
> > 
> > proper fix is at http://marc.info/?l=linux-kernel&m=125302459621925
> > 
> > we still have to figure out who's gonna pick it up. Ingo?
> > 
> 
> This was from a tree you pushed straight to Linus, so it's probably
> better you push it directly.
> 
> You can add:
> 
> Acked-by: H. Peter Anvin <hpa@zytor.com>

Cool, thanks. Will prep a pull request in a couple of hours.

-- 
Regards/Gruss,
Boris.

Operating | Advanced Micro Devices GmbH
  System  | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany
 Research | Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
  Center  | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
  (OSRC)  | Registergericht München, HRB Nr. 43632

Re: [PATCH] edac: need to export cpu_llc_id

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

Hi Boris,

On Wed, 16 Sep 2009 06:41:51 +0200 Borislav Petkov <borislav.petkov@amd.com> wrote:
>
> proper fix is at http://marc.info/?l=linux-kernel&m=125302459621925

Great, thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] edac: need to export cpu_llc_id

[Borislav Petkov]

On Thu, Sep 17, 2009 at 01:49:01AM +1000, Stephen Rothwell wrote:
> Hi Boris,
> 
> On Wed, 16 Sep 2009 06:41:51 +0200 Borislav Petkov <borislav.petkov@amd.com> wrote:
> >
> > proper fix is at http://marc.info/?l=linux-kernel&m=125302459621925
> 
> Great, thanks.

By the way, fix is already underway to Linus so you might just wait
a while before applying it to your linux-next mix and pull it from
upstream instead.

-- 
Regards/Gruss,
Boris.

Operating | Advanced Micro Devices GmbH
  System  | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany
 Research | Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
  Center  | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
  (OSRC)  | Registergericht München, HRB Nr. 43632

Re: [PATCH] edac: need to export cpu_llc_id

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 555 bytes --]

Hi Boris,

On Wed, 16 Sep 2009 18:04:20 +0200 Borislav Petkov <borislav.petkov@amd.com> wrote:
>
> By the way, fix is already underway to Linus so you might just wait
> a while before applying it to your linux-next mix and pull it from
> upstream instead.

Since Linus hasn't merged your tree yet, I have cherry-picked that one
commit from your tree into my "fixes" tree for today.  I will drop it
when Linus takes your tree.

Thanks.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]