From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH -next] input: serio_libps2 depends on serio_i8042
Date: Fri, 25 Sep 2009 15:29:02 -0700 [thread overview]
Message-ID: <20090925222901.GC8618@core.coreip.homeip.net> (raw)
In-Reply-To: <4ABD4219.5000608@oracle.com>
On Fri, Sep 25, 2009 at 03:20:09PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> SERIO_LIBPS2 code uses SERIO_I8042 code, so the former
> needs to depend on the latter.
>
Umm, it should be useable without i8042... But I guess you have
SERIO_LIBPS2=y but SERIO_I8042=m?
> (.text+0x1f33ca): undefined reference to `i8042_check_port_owner'
> (.text+0x1f33de): undefined reference to `i8042_unlock_chip'
> (.text+0x1f3435): undefined reference to `i8042_check_port_owner'
> (.text+0x1f3449): undefined reference to `i8042_lock_chip
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> drivers/input/serio/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20090925.orig/drivers/input/serio/Kconfig
> +++ linux-next-20090925/drivers/input/serio/Kconfig
> @@ -168,6 +168,7 @@ config SERIO_MACEPS2
>
> config SERIO_LIBPS2
> tristate "PS/2 driver library" if EMBEDDED
> + depends on SERIO_I8042
> help
> Say Y here if you are using a driver for device connected
> to a PS/2 port, such as PS/2 mouse or standard AT keyboard.
--
Dmitry
next prev parent reply other threads:[~2009-09-25 22:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-25 3:38 linux-next: Tree for September 25 Stephen Rothwell
2009-09-25 13:19 ` linux-next: 20090925 - build breaks with !CONFIG_AIO Kamalesh Babulal
2009-09-26 11:37 ` Martin Schwidefsky
2009-09-25 13:31 ` linux-next: 20090925 - hvc driver build breaks with !HVC_CONSOLE Kamalesh Babulal
2009-09-25 22:20 ` [PATCH -next] i2c: uses/select RT_MUTEXES Randy Dunlap
2009-09-26 9:47 ` Jean Delvare
2009-09-25 22:20 ` [PATCH -next] input: serio_libps2 depends on serio_i8042 Randy Dunlap
2009-09-25 22:29 ` Dmitry Torokhov [this message]
2009-09-25 22:30 ` Randy Dunlap
2009-09-25 23:03 ` [PATCH -next] drbd: trace depends on TRACING Randy Dunlap
[not found] ` <4ABD4C28.9070202-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2009-09-29 15:32 ` Philipp Reisner
[not found] ` <200909291732.51383.philipp.reisner-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org>
2009-09-29 15:37 ` Christoph Hellwig
2009-09-30 8:02 ` [Drbd-dev] " Lars Ellenberg
2009-09-30 16:00 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090925222901.GC8618@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).