* next-1007: dmar fails to build
@ 2009-10-07 8:50 Alexander Beregalov
2009-10-07 8:59 ` Alexander Beregalov
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Beregalov @ 2009-10-07 8:50 UTC (permalink / raw)
To: linux-next, Suresh Siddha, David Woodhouse
drivers/pci/dmar.c: In function 'dmar_parse_one_rhsa':
drivers/pci/dmar.c:360: error: implicit declaration of function
'acpi_map_pxm_to_node'
$ grep NUMA .config
$
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: next-1007: dmar fails to build
2009-10-07 8:50 next-1007: dmar fails to build Alexander Beregalov
@ 2009-10-07 8:59 ` Alexander Beregalov
2009-10-07 17:05 ` Suresh Siddha
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Beregalov @ 2009-10-07 8:59 UTC (permalink / raw)
To: linux-next, Suresh Siddha, David Woodhouse
On Wed, Oct 07, 2009 at 12:50:39PM +0400, Alexander Beregalov wrote:
> drivers/pci/dmar.c: In function 'dmar_parse_one_rhsa':
> drivers/pci/dmar.c:360: error: implicit declaration of function
> 'acpi_map_pxm_to_node'
>
> $ grep NUMA .config
> $
By the way, shouldn't it be as following?
diff --git a/drivers/pci/dmar.c b/drivers/pci/dmar.c
index 63aa529..474c7e8 100644
--- a/drivers/pci/dmar.c
+++ b/drivers/pci/dmar.c
@@ -362,8 +362,8 @@ dmar_parse_one_rhsa(struct acpi_dmar_header *header)
if (!node_online(node))
node = -1;
drhd->iommu->node = node;
- return 0;
- }
+ return 0;
+ }
return -ENODEV;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: next-1007: dmar fails to build
2009-10-07 8:59 ` Alexander Beregalov
@ 2009-10-07 17:05 ` Suresh Siddha
0 siblings, 0 replies; 3+ messages in thread
From: Suresh Siddha @ 2009-10-07 17:05 UTC (permalink / raw)
To: Alexander Beregalov; +Cc: linux-next, Woodhouse, David
On Wed, 2009-10-07 at 01:59 -0700, Alexander Beregalov wrote:
> On Wed, Oct 07, 2009 at 12:50:39PM +0400, Alexander Beregalov wrote:
> > drivers/pci/dmar.c: In function 'dmar_parse_one_rhsa':
> > drivers/pci/dmar.c:360: error: implicit declaration of function
> > 'acpi_map_pxm_to_node'
> >
> > $ grep NUMA .config
> > $
>
> By the way, shouldn't it be as following?
>
> diff --git a/drivers/pci/dmar.c b/drivers/pci/dmar.c
> index 63aa529..474c7e8 100644
> --- a/drivers/pci/dmar.c
> +++ b/drivers/pci/dmar.c
> @@ -362,8 +362,8 @@ dmar_parse_one_rhsa(struct acpi_dmar_header *header)
> if (!node_online(node))
> node = -1;
> drhd->iommu->node = node;
> - return 0;
> - }
> + return 0;
> + }
>
> return -ENODEV;
> }
Thanks. Just posted fixes for both these issues!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-10-07 17:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-07 8:50 next-1007: dmar fails to build Alexander Beregalov
2009-10-07 8:59 ` Alexander Beregalov
2009-10-07 17:05 ` Suresh Siddha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).