From: Ingo Molnar <mingo@elte.hu>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
lenb@kernel.org, linux-next@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] thinkpad_acpi: fix build, HOTKEY_POLL is optional
Date: Mon, 12 Oct 2009 14:59:42 +0200 [thread overview]
Message-ID: <20091012125942.GA25464@elte.hu> (raw)
In-Reply-To: <20091010000808.GA10637@khazad-dum.debian.net>
* Henrique de Moraes Holschuh <hmh@hmh.eng.br> wrote:
> On Fri, 09 Oct 2009, Randy Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > Fix optional part of driver to be built optionally:
>
> NAK!
>
> This happens because of (linux-next) commit
> 7f6443f7238a0aa9014b11a0a31ab76825d75cdf
> "thinkpad-acpi: Fix build on !CONFIG_THINKPAD_ACPI_HOTKEY_POLL" by
> Ingo.
>
> That commit is wrong, it must NOT be applied as explained in the
> thread starting at http://lkml.org/lkml/2009/9/27/30.
Yep, that was wrong - it should be gone now.
Ingo
next prev parent reply other threads:[~2009-10-12 12:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-09 8:06 linux-next: Tree for October 9 Stephen Rothwell
2009-10-09 23:17 ` [PATCH -next] thinkpad_acpi: fix build, HOTKEY_POLL is optional Randy Dunlap
2009-10-10 0:08 ` Henrique de Moraes Holschuh
2009-10-12 12:59 ` Ingo Molnar [this message]
2009-10-12 15:41 ` Henrique de Moraes Holschuh
[not found] ` <20091009190654.741eeffd.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2009-10-09 23:17 ` [PATCH -next] libertas: depends on CFG80211 Randy Dunlap
[not found] ` <20091009161730.6ae5fe59.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2009-10-12 7:11 ` Holger Schurig
2009-10-12 7:18 ` Holger Schurig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091012125942.GA25464@elte.hu \
--to=mingo@elte.hu \
--cc=hmh@hmh.eng.br \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).