From mboxrd@z Thu Jan 1 00:00:00 1970 From: Henrique de Moraes Holschuh Subject: Re: [PATCH -next] thinkpad_acpi: fix build, HOTKEY_POLL is optional Date: Mon, 12 Oct 2009 12:41:47 -0300 Message-ID: <20091012154147.GA16178@khazad-dum.debian.net> References: <20091009190654.741eeffd.sfr@canb.auug.org.au> <20091009161723.b68b91a7.randy.dunlap@oracle.com> <20091010000808.GA10637@khazad-dum.debian.net> <20091012125942.GA25464@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from out1.smtp.messagingengine.com ([66.111.4.25]:33783 "EHLO out1.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752790AbZJLPm3 (ORCPT ); Mon, 12 Oct 2009 11:42:29 -0400 Content-Disposition: inline In-Reply-To: <20091012125942.GA25464@elte.hu> Sender: linux-next-owner@vger.kernel.org List-ID: To: Ingo Molnar Cc: Randy Dunlap , Stephen Rothwell , lenb@kernel.org, linux-next@vger.kernel.org, LKML On Mon, 12 Oct 2009, Ingo Molnar wrote: > * Henrique de Moraes Holschuh wrote: > > On Fri, 09 Oct 2009, Randy Dunlap wrote: > > > From: Randy Dunlap > > > > > > Fix optional part of driver to be built optionally: > > > > NAK! > > > > This happens because of (linux-next) commit > > 7f6443f7238a0aa9014b11a0a31ab76825d75cdf > > "thinkpad-acpi: Fix build on !CONFIG_THINKPAD_ACPI_HOTKEY_POLL" by > > Ingo. > > > > That commit is wrong, it must NOT be applied as explained in the > > thread starting at http://lkml.org/lkml/2009/9/27/30. > > Yep, that was wrong - it should be gone now. Thank you. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh