From: Ingo Molnar <mingo@elte.hu>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: tip tree build warning
Date: Wed, 28 Oct 2009 08:50:12 +0100 [thread overview]
Message-ID: <20091028075012.GD19402@elte.hu> (raw)
In-Reply-To: <20091028184851.504752ef.sfr@canb.auug.org.au>
* Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> On Wed, 28 Oct 2009 18:41:26 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > static inline physid_mask_t default_apicid_to_cpu_present(int phys_apicid)
> > {
> > return physid_mask_of_physid(phys_apicid);
> > }
>
> I just noticed that this function (default_apicid_to_cpu_present) is
> declared "static inline in a header" but looks like it is only used by
> assigning its address to a function pointer. Its only use for x86_64
> is in arch/x86/kernel/apic/apic_noop.c ...
yes, that might be a real problem - returning the mask like that is
messy. Thanks, will check.
Ingo
next prev parent reply other threads:[~2009-10-28 7:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-28 7:14 linux-next: tip tree build warning Stephen Rothwell
2009-10-28 7:31 ` Ingo Molnar
2009-10-28 7:41 ` Stephen Rothwell
2009-10-28 7:48 ` Stephen Rothwell
2009-10-28 7:50 ` Ingo Molnar [this message]
2009-11-08 13:16 ` Cyrill Gorcunov
2009-11-08 13:32 ` Ingo Molnar
2009-11-08 13:43 ` Cyrill Gorcunov
2009-11-08 18:42 ` Cyrill Gorcunov
2009-11-08 23:39 ` Stephen Rothwell
2009-11-08 21:30 ` Cyrill Gorcunov
2009-11-09 8:10 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2010-02-01 7:22 Stephen Rothwell
2010-02-01 7:12 Stephen Rothwell
2009-12-30 23:45 Stephen Rothwell
2009-12-11 4:38 Stephen Rothwell
2009-11-25 10:53 Stephen Rothwell
2009-11-25 12:28 ` Frederic Weisbecker
2009-11-16 5:25 Stephen Rothwell
2009-11-16 17:05 ` Randy Dunlap
2009-11-23 18:05 ` Randy Dunlap
2009-10-13 3:42 Stephen Rothwell
2009-09-11 8:56 Stephen Rothwell
2009-09-13 20:20 ` Geert Uytterhoeven
2009-08-04 6:16 Stephen Rothwell
2009-08-04 16:24 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091028075012.GD19402@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).