From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: linux-next: sparc tree build failure Date: Fri, 06 Nov 2009 00:26:51 -0800 (PST) Message-ID: <20091106.002651.21006753.davem@davemloft.net> References: <20091106180248.7a6aa9ba.sfr@canb.auug.org.au> <20091106.001930.121210402.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:44780 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753750AbZKFI00 (ORCPT ); Fri, 6 Nov 2009 03:26:26 -0500 In-Reply-To: <20091106.001930.121210402.davem@davemloft.net> Sender: linux-next-owner@vger.kernel.org List-ID: To: sfr@canb.auug.org.au Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, kristoffer@gaisler.com From: David Miller Date: Fri, 06 Nov 2009 00:19:30 -0800 (PST) > From: Stephen Rothwell > Date: Fri, 6 Nov 2009 18:02:48 +1100 > >> Caused by commit d4ac42a582e46d7f86f0acb4253a310423c72c4c ("sparc: >> Support for GRLIB APBUART serial port") (yes again :-)). I have applied >> my patch to make it only build on SPARC again ... >> >> (Including linux/of_platform.h - where struct of_platform_driver, >> of_register_driver() and of_platform_bus_type are declared - would be a >> good start ... and the code should probably be using >> of_register_platform_driver() instead of of_register_driver() in any >> case.) > > Sorry, sparc is getting those headers indirectly. > > I'll fix this up. Stephen, can you let me know if this takes care of everything? I also noticed that the of_driver was not being unregistered on module unload. apbuart: Fix build and missing driver unregister. linux/of_platform.h needs to be included OF driver needs to be unregistered Signed-off-by: David S. Miller