From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: linux-next: sparc tree build failure Date: Fri, 06 Nov 2009 00:27:31 -0800 (PST) Message-ID: <20091106.002731.247254978.davem@davemloft.net> References: <20091106180248.7a6aa9ba.sfr@canb.auug.org.au> <20091106.001930.121210402.davem@davemloft.net> <20091106.002651.21006753.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:44785 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753750AbZKFI1F (ORCPT ); Fri, 6 Nov 2009 03:27:05 -0500 In-Reply-To: <20091106.002651.21006753.davem@davemloft.net> Sender: linux-next-owner@vger.kernel.org List-ID: To: sfr@canb.auug.org.au Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, kristoffer@gaisler.com From: David Miller Date: Fri, 06 Nov 2009 00:26:51 -0800 (PST) > apbuart: Fix build and missing driver unregister. > > linux/of_platform.h needs to be included > > OF driver needs to be unregistered > > Signed-off-by: David S. Miller Sorry left out the patch :-) Here it is: diff --git a/drivers/serial/apbuart.c b/drivers/serial/apbuart.c index 5f9dec3..a1e9503 100644 --- a/drivers/serial/apbuart.c +++ b/drivers/serial/apbuart.c @@ -25,6 +25,7 @@ #include #include #include +#include #include #include #include @@ -676,8 +677,7 @@ static int __init grlib_apbuart_init(void) return ret; } - ret = of_register_driver(&grlib_apbuart_of_driver, &of_platform_bus_type); - + ret = of_register_platform_driver(&grlib_apbuart_of_driver); if (ret) { printk(KERN_ERR "%s: of_register_platform_driver failed (%i)\n", @@ -698,7 +698,7 @@ static void __exit grlib_apbuart_exit(void) &grlib_apbuart_ports[i]); uart_unregister_driver(&grlib_apbuart_driver); - + of_unregister_platform_driver(&grlib_apbuart_of_driver); } module_init(grlib_apbuart_init); -- 1.6.5.2