From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: linux-next: pcmcia tree build warning
Date: Mon, 9 Nov 2009 14:54:51 +1100 [thread overview]
Message-ID: <20091109145451.c9f1c4c3.sfr@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 754 bytes --]
Hi Dominik,
Today's linux-next build (x86_64 allmodconfig) produced this warning:
drivers/char/pcmcia/cm4000_cs.c: In function 'cmm_ioctl':
/scratch/sfr/next/drivers/char/pcmcia/cm4000_cs.c:1630: warning: the frame size of 2176 bytes is larger than 2048 bytes
Introduced by commit 7194198b163c83725f52ce8e34b24cca053deea7 ("pcmcia:
use dynamic debug infrastructure, deprecate CS_CHECK (char)") which
unconditionalised "char *ioctl_names[CM_IOC_MAXNR + 1]" on the stack.
CM_IOC_MAXNR is 255, so this adds 2k to the stack frame just to allow the
printing of one of five ioctl names in a debug message. It could be made
static ...
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next reply other threads:[~2009-11-09 3:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 3:54 Stephen Rothwell [this message]
2009-11-09 7:32 ` linux-next: pcmcia tree build warning Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091109145451.c9f1c4c3.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox