linux-next: i7core_edac tree build failure

linux-next: i7core_edac tree build failure

[Stephen Rothwell]

Hi Mauro,

Today's linux-next build (x86_64 allmodconfig) failed like this:

tmp_exports-asm.o: In function `__ksymtab_pci_legacy_init':
(__ksymtab_gpl_sorted+0x3120): undefined reference to `pci_legacy_init'

Caused by commit a120a84ebbc4cbc9c1addddd2b491e3683b842a6 ("pci: Add a
probing code that seeks for an specific bus") (which applies
EXPORT_SYMBOL_GPL() to a static function) interacting with the rr tree's
changes.

I have applied the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 12 Nov 2009 16:55:38 +1100
Subject: [PATCH] i7core_edac: do not export static functions

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/x86/pci/legacy.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/x86/pci/legacy.c b/arch/x86/pci/legacy.c
index 5e22d83..a8194c8 100644
--- a/arch/x86/pci/legacy.c
+++ b/arch/x86/pci/legacy.c
@@ -38,7 +38,6 @@ static int __init pci_legacy_init(void)
 
 	return 0;
 }
-EXPORT_SYMBOL_GPL(pci_legacy_init);
 
 void pcibios_scan_specific_bus(int busn)
 {
-- 
1.6.5.2

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: linux-next: i7core_edac tree build failure

[Rusty Russell]

On Thu, 12 Nov 2009 04:28:52 pm Stephen Rothwell wrote:
> Hi Mauro,
> 
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> tmp_exports-asm.o: In function `__ksymtab_pci_legacy_init':
> (__ksymtab_gpl_sorted+0x3120): undefined reference to `pci_legacy_init'
> 
> Caused by commit a120a84ebbc4cbc9c1addddd2b491e3683b842a6 ("pci: Add a
> probing code that seeks for an specific bus") (which applies
> EXPORT_SYMBOL_GPL() to a static function) interacting with the rr tree's
> changes.

Yep, thanks Stephen.  I can't apply this fix to my tree since that function
isn't exported in Linus' tree.  I've pulled in the ppc and sparc fixes to my
tree though, but assume they'll go into their proper homes soon.

Thanks,
Rusty.

Re: linux-next: i7core_edac tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

Hi Rusty, Mauro,

On Thu, 12 Nov 2009 23:40:25 +1030 Rusty Russell <rusty@rustcorp.com.au> wrote:
>
> Yep, thanks Stephen.  I can't apply this fix to my tree since that function
> isn't exported in Linus' tree.  I've pulled in the ppc and sparc fixes to my
> tree though, but assume they'll go into their proper homes soon.

Yeah, the i7core_edac fix needs to stay in my tree as it is an
interaction between two trees in linux-next.  The others should be
applied to the powerpc and sparc trees, as you say, since they fix the
current code in those trees.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: i7core_edac tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

Hi Mauro,

On Fri, 13 Nov 2009 10:54:35 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Yeah, the i7core_edac fix needs to stay in my tree as it is an
> interaction between two trees in linux-next.  The others should be
> applied to the powerpc and sparc trees, as you say, since they fix the
> current code in those trees.

Actually, Mauro, this patch should be applied to the i7core_edac as that
symbol never needed to be exported and the patch to export it is in that
tree.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: i7core_edac tree build failure

[Stephen Rothwell]

Hi Mauro,

On Mon, 16 Nov 2009 10:30:02 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Fri, 13 Nov 2009 10:54:35 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Yeah, the i7core_edac fix needs to stay in my tree as it is an
> > interaction between two trees in linux-next.  The others should be
> > applied to the powerpc and sparc trees, as you say, since they fix the
> > current code in those trees.
> 
> Actually, Mauro, this patch should be applied to the i7core_edac as that
> symbol never needed to be exported and the patch to export it is in that
> tree.

Is there any reason that this patch (copied below) cannot be applied to
the i7core_edac tree?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 12 Nov 2009 16:55:38 +1100
Subject: [PATCH] i7core_edac: do not export static functions

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/x86/pci/legacy.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/x86/pci/legacy.c b/arch/x86/pci/legacy.c
index 5e22d83..a8194c8 100644
--- a/arch/x86/pci/legacy.c
+++ b/arch/x86/pci/legacy.c
@@ -38,7 +38,6 @@ static int __init pci_legacy_init(void)
 
 	return 0;
 }
-EXPORT_SYMBOL_GPL(pci_legacy_init);
 
 void pcibios_scan_specific_bus(int busn)
 {
-- 
1.6.5.2