linux-next: rr tree build warning

linux-next: rr tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

Hi Rusty,

Today's linux-next build (i386 defconfig) produced this warning:

kernel/module.c:1953: warning: 'crc_section_names' defined but not used

Introduced by commit 67260d90118a2394df528fe4e37e814d950ca5b5 ("module:
refactor symbol tables and try to reduce code size of each_symbol()").
This build has CONFIG_MODVERSIONS disabled.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: rr tree build warning

[Rusty Russell]

On Thu, 12 Nov 2009 06:51:14 pm Stephen Rothwell wrote:
> Hi Rusty,
> 
> Today's linux-next build (i386 defconfig) produced this warning:
> 
> kernel/module.c:1953: warning: 'crc_section_names' defined but not used
> 
> Introduced by commit 67260d90118a2394df528fe4e37e814d950ca5b5 ("module:
> refactor symbol tables and try to reduce code size of each_symbol()").
> This build has CONFIG_MODVERSIONS disabled.

Thanks.  I hit that warning in my config too, but didn't notice :(

Subject: Fix warning for CONFIG_MODVERSIONS=n:

linux-next Maestro Stephen Rothwell reports:
	Today's linux-next build (i386 defconfig) produced this warning:

	kernel/module.c:1953: warning: 'crc_section_names' defined but not used

	Introduced by commit 67260d90118a2394df528fe4e37e814d950ca5b5 ("module:
	refactor symbol tables and try to reduce code size of each_symbol()").
	This build has CONFIG_MODVERSIONS disabled.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

diff --git a/kernel/module.c b/kernel/module.c
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -1075,6 +1075,16 @@ static int try_to_force_load(struct modu
 }
 
 #ifdef CONFIG_MODVERSIONS
+static const char *crc_section_names[] = {
+	[EXPORT_TYPE_PLAIN] = "__kcrctab",
+	[EXPORT_TYPE_GPL] = "__kcrctab_gpl",
+#ifdef CONFIG_UNUSED_SYMBOLS
+	[EXPORT_TYPE_UNUSED] = "__kcrctab_unused",
+	[EXPORT_TYPE_UNUSED_GPL] = "__kcrctab_unused_gpl",
+#endif
+	[EXPORT_TYPE_GPL_FUTURE] = "__kcrctab_gpl_future",
+};
+
 static int check_version(Elf_Shdr *sechdrs,
 			 unsigned int versindex,
 			 const char *symname,
@@ -2103,16 +2113,6 @@ static const char *export_section_names[
 	[EXPORT_TYPE_GPL_FUTURE] = "__ksymtab_gpl_future",
 };
 
-static const char *crc_section_names[] = {
-	[EXPORT_TYPE_PLAIN] = "__kcrctab",
-	[EXPORT_TYPE_GPL] = "__kcrctab_gpl",
-#ifdef CONFIG_UNUSED_SYMBOLS
-	[EXPORT_TYPE_UNUSED] = "__kcrctab_unused",
-	[EXPORT_TYPE_UNUSED_GPL] = "__kcrctab_unused_gpl",
-#endif
-	[EXPORT_TYPE_GPL_FUTURE] = "__kcrctab_gpl_future",
-};
-
 /* Allocate and load the module: note that size of section 0 is always
    zero, and we rely on this for optional sections. */
 static noinline struct module *load_module(void __user *umod,

linux-next: rr tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 445 bytes --]

Hi Rusty,

Today's linux-next build (x86_64 allmodconfig) produced this warning:

usr/include/linux/kernel.h:53: userspace cannot call function or variable defined in the kernel

(it is the line "extern int __build_bug_on_failed;")

Introduced by commit 3cab06406acbf7f86f443bbde56e28f8047c75b6
("misc:enhance-BUILD_BUG_ON").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

linux-next: rr tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

Hi Rusty,

Today's linux-next build (x86_64 allmodconfig) produced this warning:

arch/x86/kernel/cpu/cpufreq/powernow-k8.c:1287: warning: passing argument 1 of 'check_supported_cpu' makes pointer from integer without a cast
arch/x86/kernel/cpu/cpufreq/powernow-k8.c:514: note: expected 'void *' but argument is of type 'unsigned int'

Introduced by commit b3594a9ce5fb32533084ec75f1954c93f461591d ("cpumask:
avoid playing with cpus_allowed in powernow-k8.c").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: rr tree build warning

[Rusty Russell]

On Tue, 9 Jun 2009 03:56:36 pm Stephen Rothwell wrote:
> Hi Rusty,
>
> Today's linux-next build (x86_64 allmodconfig) produced this warning:
>
> arch/x86/kernel/cpu/cpufreq/powernow-k8.c:1287: warning: passing argument 1
> of 'check_supported_cpu' makes pointer from integer without a cast
> arch/x86/kernel/cpu/cpufreq/powernow-k8.c:514: note: expected 'void *' but
> argument is of type 'unsigned int'
>
> Introduced by commit b3594a9ce5fb32533084ec75f1954c93f461591d ("cpumask:
> avoid playing with cpus_allowed in powernow-k8.c").

Thanks, I've revisited this patch and fixed this too.

Thanks,
Rusty.

Re: linux-next: rr tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

Hi Rusty,

On Wed, 10 Jun 2009 16:10:17 +0930 Rusty Russell <rusty@rustcorp.com.au> wrote:
>
> Thanks, I've revisited this patch and fixed this too.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

linux-next: rr tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

Hi Rusty,

Today's linux-next build (powerpc allnoconfig) produced this new warning:

kernel/workqueue.c: In function 'current_is_keventd':
kernel/workqueue.c:742: warning: unused variable 'cpu'

A UP config interacting with per_cpu_ptr()?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

linux-next: rr tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1339 bytes --]

Hi Rusty,

The next-20081204 build (powerpc ppc64_defconfig) produced these warnings:

include/linux/cpumask.h: In function 'set_cpu_possible':
include/linux/cpumask.h:1052: warning: passing argument 2 of 'cpumask_set_cpu' discards qualifiers from pointer target type
include/linux/cpumask.h:1054: warning: passing argument 2 of 'cpumask_clear_cpu' discards qualifiers from pointer target type
include/linux/cpumask.h: In function 'set_cpu_present':
include/linux/cpumask.h:1060: warning: passing argument 2 of 'cpumask_set_cpu' discards qualifiers from pointer target type
include/linux/cpumask.h:1062: warning: passing argument 2 of 'cpumask_clear_cpu' discards qualifiers from pointer target type
include/linux/cpumask.h: In function 'set_cpu_online':
include/linux/cpumask.h:1068: warning: passing argument 2 of 'cpumask_set_cpu' discards qualifiers from pointer target type
include/linux/cpumask.h:1070: warning: passing argument 2 of 'cpumask_clear_cpu' discards qualifiers from pointer target type

Caused by commit 38b04c5f8ddd01137b1524b126ac936d87b58213
("cpumask:cpu_online_mask-etc-as-primary") from the rr tree. Gcc (version
4.2.4) doesn't seem to let you just cast away the "const" from a variable.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

linux-next: rr tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

Hi Rusty,

Today's linux-next build (powerpc ppc64_defconfig) got this warning:

kernel/workqueue.c: In function 'work_on_cpu':
kernel/workqueue.c:1009: warning: passing argument 1 of 'flush_workqueue' from incompatible pointer type

You are passing a "struct work_struct *" to fluxh_workqueue which wants a
"struct workqueue_struct *".

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: rr tree build warning

[Rusty Russell]

On Friday 24 October 2008 13:34:07 Stephen Rothwell wrote:
> Hi Rusty,
>
> Today's linux-next build (powerpc ppc64_defconfig) got this warning:
>
> kernel/workqueue.c: In function 'work_on_cpu':
> kernel/workqueue.c:1009: warning: passing argument 1 of 'flush_workqueue'
> from incompatible pointer type
>
> You are passing a "struct work_struct *" to fluxh_workqueue which wants a
> "struct workqueue_struct *".

Please s/flush_workqueue/flush_work/.  Somehow I missed that warning (and
didn't re-test after that trivial change).

Tested, even.

diff -r 4d829bda1768 kernel/workqueue.c
--- a/kernel/workqueue.c	Fri Oct 24 14:10:09 2008 +1100
+++ b/kernel/workqueue.c	Fri Oct 24 14:10:58 2008 +1100
@@ -1006,7 +1006,7 @@ long work_on_cpu(unsigned int cpu, long 
 		wfc.ret = -EINVAL;
 	else {
 		schedule_work_on(cpu, &wfc.work);
-		flush_workqueue(&wfc.work);
+		flush_work(&wfc.work);
 	}
 	put_online_cpus();
 
Sorry,
Rusty.