From: Gregory Haskins <ghaskins@novell.com>
To: linux-next@vger.kernel.org
Subject: [PATCH] vbus: make dev_attr_modalias static to avoid conflicts with Xen
Date: Tue, 24 Nov 2009 07:45:50 -0500 [thread overview]
Message-ID: <20091124124550.22031.5752.stgit@dev.haskins.net> (raw)
Stephen Rothwell wrote:
> Hi Gregory,
>
> Today's linux-next build (x86_6 _allmodconfig) failed like this:
>
> drivers/vbus/built-in.o:(.data+0x0): multiple definition of `dev_attr_modalias'
> drivers/xen/built-in.o:(.data+0x46d0): first defined here
>
> Caused by commit 59aa8f441d27c8470764a513dafa46a77f33e953 ("vbus: add
> autoprobe capability to guest"). The DEVICE_ATTR(modalias ...) should
> probably be static. I should probably be static in
> drivers/xen/xenbus/xenbus_probe.c as well.
>
> I have used the version of the alacrity tree from next-20091123 for today.
>
This patch addresses the issue
Signed-off-by: Gregory Haskins <ghaskins@novell.com>
---
drivers/vbus/bus-proxy.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/vbus/bus-proxy.c b/drivers/vbus/bus-proxy.c
index 106e2fe..a318c67 100644
--- a/drivers/vbus/bus-proxy.c
+++ b/drivers/vbus/bus-proxy.c
@@ -115,7 +115,7 @@ static ssize_t _show_modalias(struct device *dev,
{
return sprintf(buf, "vbus-proxy:%s\n", to_dev(dev)->type);
}
-DEVICE_ATTR(modalias, S_IRUSR | S_IRGRP | S_IROTH, _show_modalias, NULL);
+static DEVICE_ATTR(modalias, S_IRUSR | S_IRGRP | S_IROTH, _show_modalias, NULL);
int vbus_device_proxy_register(struct vbus_device_proxy *new)
{
reply other threads:[~2009-11-24 12:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091124124550.22031.5752.stgit@dev.haskins.net \
--to=ghaskins@novell.com \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).