From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH 1/4 tip/sched/core] sched: rename preempt_notifier to sched_notifier and always enable it Date: Fri, 27 Nov 2009 07:13:19 +0100 Message-ID: <20091127061319.GA8620@elte.hu> References: <20091126102936.GA1196@elte.hu> <1259231565.4273.31.camel@twins> <1259234619.4273.32.camel@twins> <20091126115605.GA15189@elte.hu> <1259239259.4273.82.camel@twins> <4B0F356B.3040206@kernel.org> <20091127045209.GA13914@elte.hu> <4B0F65DD.1090707@kernel.org> <20091127054621.GA25672@elte.hu> <4B0F6B32.4090401@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx3.mail.elte.hu ([157.181.1.138]:34718 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751798AbZK0GNa (ORCPT ); Fri, 27 Nov 2009 01:13:30 -0500 Content-Disposition: inline In-Reply-To: <4B0F6B32.4090401@kernel.org> Sender: linux-next-owner@vger.kernel.org List-ID: To: Tejun Heo Cc: Peter Zijlstra , Steven Rostedt , Fr??d??ric Weisbecker , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Galbraith , Thomas Gleixner , "H. Peter Anvin" * Tejun Heo wrote: > Hello, > > 11/27/2009 02:46 PM, Ingo Molnar wrote: > > Other code will benefit from it though, such as the page fault callbacks > > i already mentioned. > > > > My position on this is rather clear: i want no new callbacks and no > > changes to callbacks in the scheduler until this situation is cleaned > > up. Five callback sites are _way_ too much - so if you want to add > > callbacks or change them, please clean it up and improve it first. > > Even changes which cause no functional differences? [...] Such as enabling preempt notifiers unconditionally? That's a functional change - it turns a so-far optional callback into an essentially mandatory one. Ingo