linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: ext3 tree build failure
@ 2009-12-02 23:22 Stephen Rothwell
  2009-12-02 23:37 ` Jan Kara
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2009-12-02 23:22 UTC (permalink / raw)
  To: Jan Kara; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 578 bytes --]

Hi Jan,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

fs/ext3/super.c: In function 'parse_options':
fs/ext3/super.c:1200: error: expected expression before 'case'

Caused by commit 1bef03b44fd8977ee7f6b556e47a8e97b97f4980 ("ext3: Support
for vfsv1 quota format") which has an obvious patch artifact (a line
begins with '+') in a !CONFIG_QUOTA section.

Please at least build test this stuff!

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: linux-next: ext3 tree build failure
  2009-12-02 23:22 linux-next: ext3 tree build failure Stephen Rothwell
@ 2009-12-02 23:37 ` Jan Kara
  0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2009-12-02 23:37 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel

  Hi Stephen,

On Thu 03-12-09 10:22:49, Stephen Rothwell wrote:
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> 
> fs/ext3/super.c: In function 'parse_options':
> fs/ext3/super.c:1200: error: expected expression before 'case'
> 
> Caused by commit 1bef03b44fd8977ee7f6b556e47a8e97b97f4980 ("ext3: Support
> for vfsv1 quota format") which has an obvious patch artifact (a line
> begins with '+') in a !CONFIG_QUOTA section.
  Ah, that's an artifact of my manual merge with other patches I have in my
tree.

> Please at least build test this stuff!
  I've tested it but with CONFIG_QUOTA enabled so this bug was hidden.
Sorry for the breakage.

									Honza

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-12-02 23:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-02 23:22 linux-next: ext3 tree build failure Stephen Rothwell
2009-12-02 23:37 ` Jan Kara

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).