From: Greg KH <greg@kroah.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Alan Cox <alan@linux.intel.com>
Subject: Re: linux-next: tty tree build failure
Date: Wed, 23 Dec 2009 16:19:22 -0800 [thread overview]
Message-ID: <20091224001922.GA26275@kroah.com> (raw)
In-Reply-To: <20091224104830.fe78906e.sfr@canb.auug.org.au>
On Thu, Dec 24, 2009 at 10:48:30AM +1100, Stephen Rothwell wrote:
> Hi Greg,
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> drivers/mmc/card/sdio_uart.c: In function 'sdio_uart_add_port':
> drivers/mmc/card/sdio_uart.c:99: warning: passing argument 1 of 'kfifo_alloc' makes pointer from integer without a cast
> include/linux/kfifo.h:110: note: expected 'struct kfifo *' but argument is of type 'long unsigned int'
> drivers/mmc/card/sdio_uart.c:99: warning: passing argument 3 of 'kfifo_alloc' makes integer from pointer without a cast
> include/linux/kfifo.h:110: note: expected 'gfp_t' but argument is of type 'struct spinlock_t *'
> drivers/mmc/card/sdio_uart.c:99: warning: assignment makes pointer from integer without a cast
> drivers/mmc/card/sdio_uart.c: In function 'sdio_uart_transmit_chars':
> drivers/mmc/card/sdio_uart.c:476: error: implicit declaration of function 'kfifo_get'
> drivers/mmc/card/sdio_uart.c: In function 'sdio_uart_write':
> drivers/mmc/card/sdio_uart.c:810: error: implicit declaration of function 'kfifo_put'
>
> Caused by commit ed30500af457c06b533549f5554671e58c4db18a ("tty:
> sdio_uart: Use kfifo instead of the messy circ stuff") interacting with
> the kfifo API change in Linus' tree.
>
> I have reverted that commit for today.
Thanks, I'll delete that commit and let Alan resubmit it as the API has
now changed.
thanks,
greg k-h
prev parent reply other threads:[~2009-12-24 0:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-23 23:48 linux-next: tty tree build failure Stephen Rothwell
2009-12-24 0:19 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091224001922.GA26275@kroah.com \
--to=greg@kroah.com \
--cc=alan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).