linux-next: tty tree build failure

linux-next: tty tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]

Hi Greg,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/mmc/card/sdio_uart.c: In function 'sdio_uart_add_port':
drivers/mmc/card/sdio_uart.c:99: warning: passing argument 1 of 'kfifo_alloc' makes pointer from integer without a cast
include/linux/kfifo.h:110: note: expected 'struct kfifo *' but argument is of type 'long unsigned int'
drivers/mmc/card/sdio_uart.c:99: warning: passing argument 3 of 'kfifo_alloc' makes integer from pointer without a cast
include/linux/kfifo.h:110: note: expected 'gfp_t' but argument is of type 'struct spinlock_t *'
drivers/mmc/card/sdio_uart.c:99: warning: assignment makes pointer from integer without a cast
drivers/mmc/card/sdio_uart.c: In function 'sdio_uart_transmit_chars':
drivers/mmc/card/sdio_uart.c:476: error: implicit declaration of function 'kfifo_get'
drivers/mmc/card/sdio_uart.c: In function 'sdio_uart_write':
drivers/mmc/card/sdio_uart.c:810: error: implicit declaration of function 'kfifo_put'

Caused by commit ed30500af457c06b533549f5554671e58c4db18a ("tty:
sdio_uart: Use kfifo instead of the messy circ stuff") interacting with
the kfifo API change in Linus' tree.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: tty tree build failure

[Greg KH]

On Thu, Dec 24, 2009 at 10:48:30AM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> drivers/mmc/card/sdio_uart.c: In function 'sdio_uart_add_port':
> drivers/mmc/card/sdio_uart.c:99: warning: passing argument 1 of 'kfifo_alloc' makes pointer from integer without a cast
> include/linux/kfifo.h:110: note: expected 'struct kfifo *' but argument is of type 'long unsigned int'
> drivers/mmc/card/sdio_uart.c:99: warning: passing argument 3 of 'kfifo_alloc' makes integer from pointer without a cast
> include/linux/kfifo.h:110: note: expected 'gfp_t' but argument is of type 'struct spinlock_t *'
> drivers/mmc/card/sdio_uart.c:99: warning: assignment makes pointer from integer without a cast
> drivers/mmc/card/sdio_uart.c: In function 'sdio_uart_transmit_chars':
> drivers/mmc/card/sdio_uart.c:476: error: implicit declaration of function 'kfifo_get'
> drivers/mmc/card/sdio_uart.c: In function 'sdio_uart_write':
> drivers/mmc/card/sdio_uart.c:810: error: implicit declaration of function 'kfifo_put'
> 
> Caused by commit ed30500af457c06b533549f5554671e58c4db18a ("tty:
> sdio_uart: Use kfifo instead of the messy circ stuff") interacting with
> the kfifo API change in Linus' tree.
> 
> I have reverted that commit for today.

Thanks, I'll delete that commit and let Alan resubmit it as the API has
now changed.

thanks,

greg k-h