* linux-next: trivial tree build failure
@ 2010-01-18 5:24 Stephen Rothwell
2010-01-18 8:36 ` Linus Walleij
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2010-01-18 5:24 UTC (permalink / raw)
To: Jiri Kosina
Cc: linux-next, linux-kernel, Christoph Egger, Linus Walleij,
Samuel Ortiz
[-- Attachment #1: Type: text/plain, Size: 1541 bytes --]
Hi Jiri,
Today's linux-next build (x86_64_allmodconfig) failed like this:
drivers/mfd/ab3100-otp.c: In function 'show_otp':
drivers/mfd/ab3100-otp.c:101: error: dereferencing pointer to incomplete type
drivers/mfd/ab3100-otp.c:104: error: implicit declaration of function 'seq_printf'
drivers/mfd/ab3100-otp.c:102: warning: unused variable 'err'
drivers/mfd/ab3100-otp.c: In function 'ab3100_otp_open':
drivers/mfd/ab3100-otp.c:116: error: implicit declaration of function 'single_open'
drivers/mfd/ab3100-otp.c:116: error: 'ab3100_otp_show' undeclared (first use in this function)
drivers/mfd/ab3100-otp.c: At top level:
drivers/mfd/ab3100-otp.c:121: error: 'seq_read' undeclared here (not in a function)
drivers/mfd/ab3100-otp.c:122: error: 'seq_lseek' undeclared here (not in a function)
drivers/mfd/ab3100-otp.c:123: error: 'single_release' undeclared here (not in a function)
drivers/mfd/ab3100-otp.c: In function 'ab3100_otp_init_debugfs':
drivers/mfd/ab3100-otp.c:134: error: 'err' undeclared (first use in this function)
drivers/mfd/ab3100-otp.c: In function 'ab3100_otp_exit_debugfs':
drivers/mfd/ab3100-otp.c:140: error: implicit declaration of function 'debugfs_remove_file'
Exposed by commit 8dcafdf0475eb4633401d1f0bf0e0d35e4ebb9d5
"CONFIG_DEBUG_FS wrongly written as CONFIG_DEBUGFS".
I have reverted that commit for today.
That file probably just needs to include <linux/seq_file.h> ...
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: trivial tree build failure
2010-01-18 5:24 linux-next: trivial tree build failure Stephen Rothwell
@ 2010-01-18 8:36 ` Linus Walleij
2010-01-18 9:01 ` Stephen Rothwell
0 siblings, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2010-01-18 8:36 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Jiri Kosina, linux-next, linux-kernel, Christoph Egger,
Linus Walleij, Samuel Ortiz
2010/1/18 Stephen Rothwell <sfr@canb.auug.org.au>:
> Exposed by commit 8dcafdf0475eb4633401d1f0bf0e0d35e4ebb9d5
> "CONFIG_DEBUG_FS wrongly written as CONFIG_DEBUGFS".
> I have reverted that commit for today.
I have sent a proper patch to Sam last night, that fix the #ifdef and
makes the code work.
> That file probably just needs to include <linux/seq_file.h> ...
Not quite, there was some code rot in the #ifdef:ed code as well.
But it should all be fixed now!
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: trivial tree build failure
2010-01-18 8:36 ` Linus Walleij
@ 2010-01-18 9:01 ` Stephen Rothwell
2010-01-18 10:17 ` Jiri Kosina
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2010-01-18 9:01 UTC (permalink / raw)
To: Linus Walleij
Cc: Jiri Kosina, linux-next, linux-kernel, Christoph Egger,
Linus Walleij, Samuel Ortiz
[-- Attachment #1: Type: text/plain, Size: 515 bytes --]
Hi Linus,
On Mon, 18 Jan 2010 09:36:29 +0100 Linus Walleij <linus.ml.walleij@gmail.com> wrote:
>
> I have sent a proper patch to Sam last night, that fix the #ifdef and
> makes the code work.
>
> > That file probably just needs to include <linux/seq_file.h> ...
>
> Not quite, there was some code rot in the #ifdef:ed code as well.
>
> But it should all be fixed now!
Excellent, thanks.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: trivial tree build failure
2010-01-18 9:01 ` Stephen Rothwell
@ 2010-01-18 10:17 ` Jiri Kosina
2010-01-18 12:56 ` Samuel Ortiz
0 siblings, 1 reply; 6+ messages in thread
From: Jiri Kosina @ 2010-01-18 10:17 UTC (permalink / raw)
To: Stephen Rothwell, Linus Walleij
Cc: linux-next, linux-kernel, Christoph Egger, Linus Walleij,
Samuel Ortiz
On Mon, 18 Jan 2010, Stephen Rothwell wrote:
> Hi Jiri,
>
> Today's linux-next build (x86_64_allmodconfig) failed like this:
>
> drivers/mfd/ab3100-otp.c: In function 'show_otp':
> drivers/mfd/ab3100-otp.c:101: error: dereferencing pointer to incomplete type
> drivers/mfd/ab3100-otp.c:104: error: implicit declaration of function 'seq_printf'
> drivers/mfd/ab3100-otp.c:102: warning: unused variable 'err'
> drivers/mfd/ab3100-otp.c: In function 'ab3100_otp_open':
> drivers/mfd/ab3100-otp.c:116: error: implicit declaration of function 'single_open'
> drivers/mfd/ab3100-otp.c:116: error: 'ab3100_otp_show' undeclared (first use in this function)
> drivers/mfd/ab3100-otp.c: At top level:
> drivers/mfd/ab3100-otp.c:121: error: 'seq_read' undeclared here (not in a function)
> drivers/mfd/ab3100-otp.c:122: error: 'seq_lseek' undeclared here (not in a function)
> drivers/mfd/ab3100-otp.c:123: error: 'single_release' undeclared here (not in a function)
> drivers/mfd/ab3100-otp.c: In function 'ab3100_otp_init_debugfs':
> drivers/mfd/ab3100-otp.c:134: error: 'err' undeclared (first use in this function)
> drivers/mfd/ab3100-otp.c: In function 'ab3100_otp_exit_debugfs':
> drivers/mfd/ab3100-otp.c:140: error: implicit declaration of function 'debugfs_remove_file'
>
> Exposed by commit 8dcafdf0475eb4633401d1f0bf0e0d35e4ebb9d5
> "CONFIG_DEBUG_FS wrongly written as CONFIG_DEBUGFS".
Hmm, mea culpa. I have noticed the build failure myself and notified patch
author about that, but forgot to drop the patch from my tree afterwards.
Sorry.
On Mon, 18 Jan 2010, Linus Walleij wrote:
> 2010/1/18 Stephen Rothwell <sfr@canb.auug.org.au>:
>
> > Exposed by commit 8dcafdf0475eb4633401d1f0bf0e0d35e4ebb9d5
> > "CONFIG_DEBUG_FS wrongly written as CONFIG_DEBUGFS".
> > I have reverted that commit for today.
>
> I have sent a proper patch to Sam last night, that fix the #ifdef and
> makes the code work.
I have dropped the patch from my tree now, and I am not carrying any
replacement as of now.
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: trivial tree build failure
2010-01-18 10:17 ` Jiri Kosina
@ 2010-01-18 12:56 ` Samuel Ortiz
2010-01-18 23:40 ` Stephen Rothwell
0 siblings, 1 reply; 6+ messages in thread
From: Samuel Ortiz @ 2010-01-18 12:56 UTC (permalink / raw)
To: Jiri Kosina
Cc: Stephen Rothwell, Linus Walleij, linux-next, linux-kernel,
Christoph Egger, Linus Walleij
Hi Jiri,
On Mon, Jan 18, 2010 at 11:17:19AM +0100, Jiri Kosina wrote:
> On Mon, 18 Jan 2010, Stephen Rothwell wrote:
>
> > Hi Jiri,
> >
> > Today's linux-next build (x86_64_allmodconfig) failed like this:
> >
> > drivers/mfd/ab3100-otp.c: In function 'show_otp':
> > drivers/mfd/ab3100-otp.c:101: error: dereferencing pointer to incomplete type
> > drivers/mfd/ab3100-otp.c:104: error: implicit declaration of function 'seq_printf'
> > drivers/mfd/ab3100-otp.c:102: warning: unused variable 'err'
> > drivers/mfd/ab3100-otp.c: In function 'ab3100_otp_open':
> > drivers/mfd/ab3100-otp.c:116: error: implicit declaration of function 'single_open'
> > drivers/mfd/ab3100-otp.c:116: error: 'ab3100_otp_show' undeclared (first use in this function)
> > drivers/mfd/ab3100-otp.c: At top level:
> > drivers/mfd/ab3100-otp.c:121: error: 'seq_read' undeclared here (not in a function)
> > drivers/mfd/ab3100-otp.c:122: error: 'seq_lseek' undeclared here (not in a function)
> > drivers/mfd/ab3100-otp.c:123: error: 'single_release' undeclared here (not in a function)
> > drivers/mfd/ab3100-otp.c: In function 'ab3100_otp_init_debugfs':
> > drivers/mfd/ab3100-otp.c:134: error: 'err' undeclared (first use in this function)
> > drivers/mfd/ab3100-otp.c: In function 'ab3100_otp_exit_debugfs':
> > drivers/mfd/ab3100-otp.c:140: error: implicit declaration of function 'debugfs_remove_file'
> >
> > Exposed by commit 8dcafdf0475eb4633401d1f0bf0e0d35e4ebb9d5
> > "CONFIG_DEBUG_FS wrongly written as CONFIG_DEBUGFS".
>
> Hmm, mea culpa. I have noticed the build failure myself and notified patch
> author about that, but forgot to drop the patch from my tree afterwards.
> Sorry.
>
> On Mon, 18 Jan 2010, Linus Walleij wrote:
>
> > 2010/1/18 Stephen Rothwell <sfr@canb.auug.org.au>:
> >
> > > Exposed by commit 8dcafdf0475eb4633401d1f0bf0e0d35e4ebb9d5
> > > "CONFIG_DEBUG_FS wrongly written as CONFIG_DEBUGFS".
> > > I have reverted that commit for today.
> >
> > I have sent a proper patch to Sam last night, that fix the #ifdef and
> > makes the code work.
>
> I have dropped the patch from my tree now, and I am not carrying any
> replacement as of now.
I'm carrying Linus patch for it, thanks.
Cheers,
Samuel.
> --
> Jiri Kosina
> SUSE Labs, Novell Inc.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: trivial tree build failure
2010-01-18 12:56 ` Samuel Ortiz
@ 2010-01-18 23:40 ` Stephen Rothwell
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2010-01-18 23:40 UTC (permalink / raw)
To: Samuel Ortiz
Cc: Jiri Kosina, Linus Walleij, linux-next, linux-kernel,
Christoph Egger, Linus Walleij
[-- Attachment #1: Type: text/plain, Size: 376 bytes --]
Hi Sam, Jiri,
On Mon, 18 Jan 2010 13:56:30 +0100 Samuel Ortiz <sameo@linux.intel.com> wrote:
>
> > I have dropped the patch from my tree now, and I am not carrying any
> > replacement as of now.
> I'm carrying Linus patch for it, thanks.
OK, thanks guys.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-01-18 23:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-18 5:24 linux-next: trivial tree build failure Stephen Rothwell
2010-01-18 8:36 ` Linus Walleij
2010-01-18 9:01 ` Stephen Rothwell
2010-01-18 10:17 ` Jiri Kosina
2010-01-18 12:56 ` Samuel Ortiz
2010-01-18 23:40 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).