From: "Michael S. Tsirkin" <mst@redhat.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
netdev <netdev@vger.kernel.org>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Tree for January 19 (vhost_net)
Date: Wed, 20 Jan 2010 13:33:41 +0200 [thread overview]
Message-ID: <20100120113341.GA9610@redhat.com> (raw)
In-Reply-To: <20100119104139.2ec9164b.randy.dunlap@oracle.com>
On Tue, Jan 19, 2010 at 10:41:39AM -0800, Randy Dunlap wrote:
> On Tue, 19 Jan 2010 18:10:41 +1100 Stephen Rothwell wrote:
>
> > Hi all,
> >
> > Changes since 20100118:
>
>
> When CONFIG_TUN is not enabled:
>
> drivers/built-in.o: In function `get_socket':
> net.c:(.text+0x2899a3): undefined reference to `tun_get_socket'
>
>
> so VHOST_NET can either depend on TUN or select TUN, but if it
> selects TUN, it will also need to select CRC32.
>
> ---
> ~Randy
Just to clarify sure, the broken configuration is VHOST=y TUN=m, I sent
a fixup patch to forbid that configuration. But both VHOST=y TUN=n and
VHOST=m TUN=n build fine for me on linux-next (commit
af2b07e7e0a9c6bf82ce4d6a77f0412ae54f575b). Randy, could you please
confirm that VHOST=y TUN=m is what you tested, or alternatively make
your .config available to me so I can reproduce the problem?
Thanks!
--
MST
next prev parent reply other threads:[~2010-01-20 11:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 7:10 linux-next: Tree for January 19 Stephen Rothwell
2010-01-19 18:41 ` linux-next: Tree for January 19 (vhost_net) Randy Dunlap
2010-01-20 10:16 ` Michael S. Tsirkin
2010-01-20 11:37 ` Stephen Rothwell
2010-01-20 11:33 ` Michael S. Tsirkin [this message]
2010-01-20 15:48 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100120113341.GA9610@redhat.com \
--to=mst@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).