From: Samuel Ortiz <sameo@linux.intel.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>
Subject: Re: [PATCH -next] mfd: htc-i2cpld depends on GPIOLIB
Date: Thu, 21 Jan 2010 13:06:05 +0100 [thread overview]
Message-ID: <20100121120604.GA6936@sortiz.org> (raw)
In-Reply-To: <4B57D036.2000001@oracle.com>
On Wed, Jan 20, 2010 at 07:55:34PM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> htc-i2cpld should depend on GPIOLIB, otherwise there are many
> build errors:
Thanks Randy, patch applied and pushed to my for-next branch.
Cheers,
Samuel.
> drivers/mfd/htc-i2cpld.c:50: error: field 'chip_out' has incomplete type
> drivers/mfd/htc-i2cpld.c:54: error: field 'chip_in' has incomplete type
> drivers/mfd/htc-i2cpld.c:243: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/mfd/htc-i2cpld.c:243: warning: initialization from incompatible pointer type
> drivers/mfd/htc-i2cpld.c:278: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/mfd/htc-i2cpld.c:278: warning: initialization from incompatible pointer type
> drivers/mfd/htc-i2cpld.c:282: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/mfd/htc-i2cpld.c:282: warning: initialization from incompatible pointer type
> drivers/mfd/htc-i2cpld.c:315: error: dereferencing pointer to incomplete type
> drivers/mfd/htc-i2cpld.c:322: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/mfd/htc-i2cpld.c:322: warning: initialization from incompatible pointer type
> drivers/mfd/htc-i2cpld.c:467+: error: dereferencing pointer to incomplete type [19X]
> drivers/mfd/htc-i2cpld.c:490: error: implicit declaration of function 'gpiochip_add'
> drivers/mfd/htc-i2cpld.c:504: error: implicit declaration of function 'gpiochip_remove'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> ---
> drivers/mfd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20100120.orig/drivers/mfd/Kconfig
> +++ linux-next-20100120/drivers/mfd/Kconfig
> @@ -80,7 +80,7 @@ config HTC_PASIC3
>
> config HTC_I2CPLD
> bool "HTC I2C PLD chip support"
> - depends on I2C=y
> + depends on I2C=y && GPIOLIB
> help
> If you say yes here you get support for the supposed CPLD
> found on omap850 HTC devices like the HTC Wizard and HTC Herald.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2010-01-21 12:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 3:55 [PATCH -next] mfd: htc-i2cpld depends on GPIOLIB Randy Dunlap
2010-01-21 12:06 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100121120604.GA6936@sortiz.org \
--to=sameo@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).