* [PATCH -next] mfd: htc-i2cpld depends on GPIOLIB
@ 2010-01-21 3:55 Randy Dunlap
2010-01-21 12:06 ` Samuel Ortiz
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2010-01-21 3:55 UTC (permalink / raw)
To: lkml, linux-next@vger.kernel.org; +Cc: Samuel Ortiz
From: Randy Dunlap <randy.dunlap@oracle.com>
htc-i2cpld should depend on GPIOLIB, otherwise there are many
build errors:
drivers/mfd/htc-i2cpld.c:50: error: field 'chip_out' has incomplete type
drivers/mfd/htc-i2cpld.c:54: error: field 'chip_in' has incomplete type
drivers/mfd/htc-i2cpld.c:243: warning: type defaults to 'int' in declaration of '__mptr'
drivers/mfd/htc-i2cpld.c:243: warning: initialization from incompatible pointer type
drivers/mfd/htc-i2cpld.c:278: warning: type defaults to 'int' in declaration of '__mptr'
drivers/mfd/htc-i2cpld.c:278: warning: initialization from incompatible pointer type
drivers/mfd/htc-i2cpld.c:282: warning: type defaults to 'int' in declaration of '__mptr'
drivers/mfd/htc-i2cpld.c:282: warning: initialization from incompatible pointer type
drivers/mfd/htc-i2cpld.c:315: error: dereferencing pointer to incomplete type
drivers/mfd/htc-i2cpld.c:322: warning: type defaults to 'int' in declaration of '__mptr'
drivers/mfd/htc-i2cpld.c:322: warning: initialization from incompatible pointer type
drivers/mfd/htc-i2cpld.c:467+: error: dereferencing pointer to incomplete type [19X]
drivers/mfd/htc-i2cpld.c:490: error: implicit declaration of function 'gpiochip_add'
drivers/mfd/htc-i2cpld.c:504: error: implicit declaration of function 'gpiochip_remove'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>
---
drivers/mfd/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20100120.orig/drivers/mfd/Kconfig
+++ linux-next-20100120/drivers/mfd/Kconfig
@@ -80,7 +80,7 @@ config HTC_PASIC3
config HTC_I2CPLD
bool "HTC I2C PLD chip support"
- depends on I2C=y
+ depends on I2C=y && GPIOLIB
help
If you say yes here you get support for the supposed CPLD
found on omap850 HTC devices like the HTC Wizard and HTC Herald.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] mfd: htc-i2cpld depends on GPIOLIB
2010-01-21 3:55 [PATCH -next] mfd: htc-i2cpld depends on GPIOLIB Randy Dunlap
@ 2010-01-21 12:06 ` Samuel Ortiz
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Ortiz @ 2010-01-21 12:06 UTC (permalink / raw)
To: Randy Dunlap; +Cc: lkml, linux-next@vger.kernel.org
On Wed, Jan 20, 2010 at 07:55:34PM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> htc-i2cpld should depend on GPIOLIB, otherwise there are many
> build errors:
Thanks Randy, patch applied and pushed to my for-next branch.
Cheers,
Samuel.
> drivers/mfd/htc-i2cpld.c:50: error: field 'chip_out' has incomplete type
> drivers/mfd/htc-i2cpld.c:54: error: field 'chip_in' has incomplete type
> drivers/mfd/htc-i2cpld.c:243: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/mfd/htc-i2cpld.c:243: warning: initialization from incompatible pointer type
> drivers/mfd/htc-i2cpld.c:278: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/mfd/htc-i2cpld.c:278: warning: initialization from incompatible pointer type
> drivers/mfd/htc-i2cpld.c:282: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/mfd/htc-i2cpld.c:282: warning: initialization from incompatible pointer type
> drivers/mfd/htc-i2cpld.c:315: error: dereferencing pointer to incomplete type
> drivers/mfd/htc-i2cpld.c:322: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/mfd/htc-i2cpld.c:322: warning: initialization from incompatible pointer type
> drivers/mfd/htc-i2cpld.c:467+: error: dereferencing pointer to incomplete type [19X]
> drivers/mfd/htc-i2cpld.c:490: error: implicit declaration of function 'gpiochip_add'
> drivers/mfd/htc-i2cpld.c:504: error: implicit declaration of function 'gpiochip_remove'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> ---
> drivers/mfd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20100120.orig/drivers/mfd/Kconfig
> +++ linux-next-20100120/drivers/mfd/Kconfig
> @@ -80,7 +80,7 @@ config HTC_PASIC3
>
> config HTC_I2CPLD
> bool "HTC I2C PLD chip support"
> - depends on I2C=y
> + depends on I2C=y && GPIOLIB
> help
> If you say yes here you get support for the supposed CPLD
> found on omap850 HTC devices like the HTC Wizard and HTC Herald.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-21 12:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-21 3:55 [PATCH -next] mfd: htc-i2cpld depends on GPIOLIB Randy Dunlap
2010-01-21 12:06 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).