From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Ortiz Subject: Re: [PATCH -next] mfd: htc-i2cpld depends on GPIOLIB Date: Thu, 21 Jan 2010 13:06:05 +0100 Message-ID: <20100121120604.GA6936@sortiz.org> References: <4B57D036.2000001@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga10.intel.com ([192.55.52.92]:50766 "EHLO fmsmga102.fm.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752706Ab0AUMEe (ORCPT ); Thu, 21 Jan 2010 07:04:34 -0500 Content-Disposition: inline In-Reply-To: <4B57D036.2000001@oracle.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Randy Dunlap Cc: lkml , "linux-next@vger.kernel.org" On Wed, Jan 20, 2010 at 07:55:34PM -0800, Randy Dunlap wrote: > From: Randy Dunlap > > htc-i2cpld should depend on GPIOLIB, otherwise there are many > build errors: Thanks Randy, patch applied and pushed to my for-next branch. Cheers, Samuel. > drivers/mfd/htc-i2cpld.c:50: error: field 'chip_out' has incomplete type > drivers/mfd/htc-i2cpld.c:54: error: field 'chip_in' has incomplete type > drivers/mfd/htc-i2cpld.c:243: warning: type defaults to 'int' in declaration of '__mptr' > drivers/mfd/htc-i2cpld.c:243: warning: initialization from incompatible pointer type > drivers/mfd/htc-i2cpld.c:278: warning: type defaults to 'int' in declaration of '__mptr' > drivers/mfd/htc-i2cpld.c:278: warning: initialization from incompatible pointer type > drivers/mfd/htc-i2cpld.c:282: warning: type defaults to 'int' in declaration of '__mptr' > drivers/mfd/htc-i2cpld.c:282: warning: initialization from incompatible pointer type > drivers/mfd/htc-i2cpld.c:315: error: dereferencing pointer to incomplete type > drivers/mfd/htc-i2cpld.c:322: warning: type defaults to 'int' in declaration of '__mptr' > drivers/mfd/htc-i2cpld.c:322: warning: initialization from incompatible pointer type > drivers/mfd/htc-i2cpld.c:467+: error: dereferencing pointer to incomplete type [19X] > drivers/mfd/htc-i2cpld.c:490: error: implicit declaration of function 'gpiochip_add' > drivers/mfd/htc-i2cpld.c:504: error: implicit declaration of function 'gpiochip_remove' > > Signed-off-by: Randy Dunlap > Cc: Samuel Ortiz > --- > drivers/mfd/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20100120.orig/drivers/mfd/Kconfig > +++ linux-next-20100120/drivers/mfd/Kconfig > @@ -80,7 +80,7 @@ config HTC_PASIC3 > > config HTC_I2CPLD > bool "HTC I2C PLD chip support" > - depends on I2C=y > + depends on I2C=y && GPIOLIB > help > If you say yes here you get support for the supposed CPLD > found on omap850 HTC devices like the HTC Wizard and HTC Herald. -- Intel Open Source Technology Centre http://oss.intel.com/