public inbox for linux-next@vger.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: geert@linux-m68k.org
Cc: adobriyan@gmail.com, linux-next@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: drivers/net/ariadne.c:165: error: 'set_multicast_list' undeclared here (not in a function)
Date: Tue, 26 Jan 2010 05:18:17 -0800 (PST)	[thread overview]
Message-ID: <20100126.051817.215651254.davem@davemloft.net> (raw)
In-Reply-To: <10f740e81001260057h37f3494dvefa3a37b2e1453a5@mail.gmail.com>

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Tue, 26 Jan 2010 09:57:05 +0100

> http://kisskb.ellerman.id.au/kisskb/buildresult/2076964/
> 
> drivers/net/ariadne.c:165: error: 'set_multicast_list' undeclared here
> (not in a function)
> 
> Seems to be broken by:

I'll fix this with the patch below.

Alexey, please go through at least drivers/net and look at the
other stale references to these HAVE_* macros.

For example I still see a bunch of HAVE_POLL_CONTROLLER stuff.

Thanks.

ariadne: Fix build.

References removed HAVE_MULTICAST.

Reporeted-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/net/ariadne.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ariadne.c b/drivers/net/ariadne.c
index c35af3e..e2c2024 100644
--- a/drivers/net/ariadne.c
+++ b/drivers/net/ariadne.c
@@ -123,9 +123,7 @@ static void ariadne_reset(struct net_device *dev);
 static irqreturn_t ariadne_interrupt(int irq, void *data);
 static int ariadne_close(struct net_device *dev);
 static struct net_device_stats *ariadne_get_stats(struct net_device *dev);
-#ifdef HAVE_MULTICAST
 static void set_multicast_list(struct net_device *dev);
-#endif
 
 
 static void memcpyw(volatile u_short *dest, u_short *src, int len)
-- 
1.6.6.1

  reply	other threads:[~2010-01-26 13:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-26  8:57 drivers/net/ariadne.c:165: error: 'set_multicast_list' undeclared here (not in a function) Geert Uytterhoeven
2010-01-26 13:18 ` David Miller [this message]
2010-01-26 19:17   ` [PATCH] netdev: remove HAVE_ leftovers Alexey Dobriyan
2010-01-27  0:32     ` David Miller
2010-01-27 20:17       ` [PATCH] netdev: remove more " Alexey Dobriyan
2010-01-28 14:01         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100126.051817.215651254.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=adobriyan@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox