From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH -next] staging/vmwgfx: depends on FB Date: Tue, 16 Feb 2010 15:05:37 -0800 Message-ID: <20100216230537.GA19450@suse.de> References: <20100216185534.fdc8eed3.sfr@canb.auug.org.au> <4B7B233F.9000507@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cantor.suse.de ([195.135.220.2]:38977 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933276Ab0BPXHO (ORCPT ); Tue, 16 Feb 2010 18:07:14 -0500 Content-Disposition: inline In-Reply-To: <4B7B233F.9000507@oracle.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Randy Dunlap Cc: Stephen Rothwell , linux-next@vger.kernel.org, LKML , devel@driverdev.osuosl.org On Tue, Feb 16, 2010 at 02:59:11PM -0800, Randy Dunlap wrote: > From: Randy Dunlap > > vmwfgx uses framebuffer interfaces, so it should depend on FB. > Otherwise it has these build errors (e.g., when CONFIG_FB=m): > > drivers/built-in.o: In function `vmw_fb_close': > (.text+0x97713): undefined reference to `unregister_framebuffer' > drivers/built-in.o: In function `vmw_fb_close': > (.text+0x97754): undefined reference to `framebuffer_release' > drivers/built-in.o: In function `vmw_fb_init': > (.text+0x97e1c): undefined reference to `framebuffer_alloc' > drivers/built-in.o: In function `vmw_fb_init': > (.text+0x9838d): undefined reference to `register_framebuffer' > drivers/built-in.o: In function `vmw_fb_init': > (.text+0x9842a): undefined reference to `framebuffer_release' > > Signed-off-by: Randy Dunlap > --- > drivers/gpu/drm/vmwgfx/Kconfig | 2 +- This is not a drivers/staging/* file, so there's not much I can do with it. It belongs to David Airlie. thanks, greg k-h