* linux-next: manual merge of the usb tree with the block tree
@ 2010-03-01 7:54 Stephen Rothwell
2010-03-01 8:04 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2010-03-01 7:54 UTC (permalink / raw)
To: Greg KH
Cc: linux-next, linux-kernel, Martin K. Petersen, Jens Axboe,
Alan Stern
Hi Greg,
Today's linux-next merge of the usb tree got a conflict in
drivers/usb/storage/scsiglue.c between commit
086fa5ff0854c676ec333760f4c0154b3b242616 ("block: Rename
blk_queue_max_sectors to blk_queue_max_hw_sectors") from the block tree
and commit 628726dbb5ebbec77336019ac4e1f60cf3ba08c1 ("usb-storage: use
max_hw_sectors instead of max_sectors") from the usb tree.
Just context changes. I fixed it up (see below) and can carry the fix as
necessary.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
diff --cc drivers/usb/storage/scsiglue.c
index aadc16b,354c38e..0000000
--- a/drivers/usb/storage/scsiglue.c
+++ b/drivers/usb/storage/scsiglue.c
@@@ -133,8 -133,8 +133,8 @@@ static int slave_configure(struct scsi_
if (us->fflags & US_FL_MAX_SECTORS_MIN)
max_sectors = PAGE_CACHE_SIZE >> 9;
- if (queue_max_sectors(sdev->request_queue) > max_sectors)
+ if (queue_max_hw_sectors(sdev->request_queue) > max_sectors)
- blk_queue_max_sectors(sdev->request_queue,
+ blk_queue_max_hw_sectors(sdev->request_queue,
max_sectors);
} else if (sdev->type == TYPE_TAPE) {
/* Tapes need much higher max_sector limits, so just
@@@ -494,9 -494,9 +494,9 @@@ static ssize_t store_max_sectors(struc
struct scsi_device *sdev = to_scsi_device(dev);
unsigned short ms;
- if (sscanf(buf, "%hu", &ms) > 0 && ms <= SCSI_DEFAULT_MAX_SECTORS) {
+ if (sscanf(buf, "%hu", &ms) > 0) {
- blk_queue_max_sectors(sdev->request_queue, ms);
+ blk_queue_max_hw_sectors(sdev->request_queue, ms);
- return strlen(buf);
+ return count;
}
return -EINVAL;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: manual merge of the usb tree with the block tree
2010-03-01 7:54 linux-next: manual merge of the usb tree with the block tree Stephen Rothwell
@ 2010-03-01 8:04 ` Jens Axboe
2010-03-02 23:10 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2010-03-01 8:04 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Greg KH, linux-next, linux-kernel, Martin K. Petersen, Alan Stern
On Mon, Mar 01 2010, Stephen Rothwell wrote:
> Hi Greg,
>
> Today's linux-next merge of the usb tree got a conflict in
> drivers/usb/storage/scsiglue.c between commit
> 086fa5ff0854c676ec333760f4c0154b3b242616 ("block: Rename
> blk_queue_max_sectors to blk_queue_max_hw_sectors") from the block tree
> and commit 628726dbb5ebbec77336019ac4e1f60cf3ba08c1 ("usb-storage: use
> max_hw_sectors instead of max_sectors") from the usb tree.
>
> Just context changes. I fixed it up (see below) and can carry the fix as
> necessary.
Thanks Stephen, looks good.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: manual merge of the usb tree with the block tree
2010-03-01 8:04 ` Jens Axboe
@ 2010-03-02 23:10 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2010-03-02 23:10 UTC (permalink / raw)
To: Jens Axboe
Cc: Stephen Rothwell, linux-next, linux-kernel, Martin K. Petersen,
Alan Stern
On Mon, Mar 01, 2010 at 09:04:03AM +0100, Jens Axboe wrote:
> On Mon, Mar 01 2010, Stephen Rothwell wrote:
> > Hi Greg,
> >
> > Today's linux-next merge of the usb tree got a conflict in
> > drivers/usb/storage/scsiglue.c between commit
> > 086fa5ff0854c676ec333760f4c0154b3b242616 ("block: Rename
> > blk_queue_max_sectors to blk_queue_max_hw_sectors") from the block tree
> > and commit 628726dbb5ebbec77336019ac4e1f60cf3ba08c1 ("usb-storage: use
> > max_hw_sectors instead of max_sectors") from the usb tree.
> >
> > Just context changes. I fixed it up (see below) and can carry the fix as
> > necessary.
>
> Thanks Stephen, looks good.
I've made these changes in the patch set I sent to Linus.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-02 23:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-01 7:54 linux-next: manual merge of the usb tree with the block tree Stephen Rothwell
2010-03-01 8:04 ` Jens Axboe
2010-03-02 23:10 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).