linux-next: build failure after merge of the final tree (input tree related)

linux-next: build failure after merge of the final tree (input tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1803 bytes --]

Hi Dmitry,

After merging the final tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

drivers/built-in.o: In function `sysrq_filter':
sysrq.c:(.text+0x224da): undefined reference to `fg_console'
sysrq.c:(.text+0x224e2): undefined reference to `fg_console'
sysrq.c:(.text+0x224f2): undefined reference to `vc_cons'
sysrq.c:(.text+0x224f6): undefined reference to `vc_cons'
drivers/built-in.o: In function `sysrq_disconnect':
sysrq.c:(.text+0x226e4): undefined reference to `input_close_device'
sysrq.c:(.text+0x226ec): undefined reference to `input_unregister_handle'
drivers/built-in.o: In function `sysrq_connect':
sysrq.c:(.text+0x22780): undefined reference to `input_register_handle'
sysrq.c:(.text+0x22790): undefined reference to `input_open_device'
sysrq.c:(.text+0x227f0): undefined reference to `input_unregister_handle'
drivers/built-in.o: In function `sysrq_toggle_support':
(.text+0x22b6c): undefined reference to `input_unregister_handler'
drivers/built-in.o: In function `sysrq_toggle_support':
(.text+0x22bac): undefined reference to `input_register_handler'
drivers/built-in.o: In function `sysrq_init':
sysrq.c:(.init.text+0x18d4): undefined reference to `input_register_handler'

Caused by commit edc6e384f9d96e54a6d03068d3b03fa5b56b6449 ("Input:
implement SysRq as a separate input handler").  This build does not have
CONFIG_HW_CONSOLE or CONFIG_INPUT set, but does have CONFIG_MAGIC_SYSRQ
set to 'y'.

For today, I have reverted that commit, commit
75394b382f16feddac9c523abf0eca8346afcf23 ("Input: keyboard - fix
formatting issues") which conflicted with the revert and the merge fixup
patch for the kgdb tree..

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build failure after merge of the final tree (input tree related)

[Dmitry Torokhov]

On Tue, Mar 23, 2010 at 05:54:56PM +1100, Stephen Rothwell wrote:
> Hi Dmitry,
> 
> After merging the final tree, today's linux-next build (powerpc
> ppc44x_defconfig) failed like this:
> 
> drivers/built-in.o: In function `sysrq_filter':
> sysrq.c:(.text+0x224da): undefined reference to `fg_console'
> sysrq.c:(.text+0x224e2): undefined reference to `fg_console'
> sysrq.c:(.text+0x224f2): undefined reference to `vc_cons'
> sysrq.c:(.text+0x224f6): undefined reference to `vc_cons'
> drivers/built-in.o: In function `sysrq_disconnect':
> sysrq.c:(.text+0x226e4): undefined reference to `input_close_device'
> sysrq.c:(.text+0x226ec): undefined reference to `input_unregister_handle'
> drivers/built-in.o: In function `sysrq_connect':
> sysrq.c:(.text+0x22780): undefined reference to `input_register_handle'
> sysrq.c:(.text+0x22790): undefined reference to `input_open_device'
> sysrq.c:(.text+0x227f0): undefined reference to `input_unregister_handle'
> drivers/built-in.o: In function `sysrq_toggle_support':
> (.text+0x22b6c): undefined reference to `input_unregister_handler'
> drivers/built-in.o: In function `sysrq_toggle_support':
> (.text+0x22bac): undefined reference to `input_register_handler'
> drivers/built-in.o: In function `sysrq_init':
> sysrq.c:(.init.text+0x18d4): undefined reference to `input_register_handler'
> 
> Caused by commit edc6e384f9d96e54a6d03068d3b03fa5b56b6449 ("Input:
> implement SysRq as a separate input handler").  This build does not have
> CONFIG_HW_CONSOLE or CONFIG_INPUT set, but does have CONFIG_MAGIC_SYSRQ
> set to 'y'.
>

Sorry about this, I did not expect Sysrq being available without input.
I will try to fix up the tree in time for your tomorrow fetch.


-- 
Dmitry

linux-next: build failure after merge of the final tree (input tree related)

[Stephen Rothwell]

Hi Dmitry,

After merging the final tree, today's linux-next build (i386 defconfig)
failed like this:

In file included from drivers/gpu/drm/i915/i915_irq.c:29:
include/linux/sysrq.h:45: error: expected declaration specifiers or '...' before 'bool'

Caused by commit a821bafce37b26499e2bfbf2e6b96b0636efc014 ("Input: sysrq
- drop tty argument form handle_sysrq()") from the input tree which
(despite not mentioning this) changed an "int" argument to "bool" but
neglected to include linux/types.h.

I added this patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 20 Aug 2010 13:06:30 +1000
Subject: [PATCH] input: using bool in sysrq.h requires including types.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/linux/sysrq.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/sysrq.h b/include/linux/sysrq.h
index 32d360a..387fa7d 100644
--- a/include/linux/sysrq.h
+++ b/include/linux/sysrq.h
@@ -15,6 +15,7 @@
 #define _LINUX_SYSRQ_H
 
 #include <linux/errno.h>
+#include <linux/types.h>
 
 /* Possible values of bitmask for enabling sysrq functions */
 /* 0x0001 is reserved for enable everything */
-- 
1.7.1

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: linux-next: build failure after merge of the final tree (input tree related)

[Dmitry Torokhov]

Hi Stephen,

On Fri, Aug 20, 2010 at 01:12:24PM +1000, Stephen Rothwell wrote:
> Hi Dmitry,
> 
> After merging the final tree, today's linux-next build (i386 defconfig)
> failed like this:
> 
> In file included from drivers/gpu/drm/i915/i915_irq.c:29:
> include/linux/sysrq.h:45: error: expected declaration specifiers or '...' before 'bool'
> 
> Caused by commit a821bafce37b26499e2bfbf2e6b96b0636efc014 ("Input: sysrq
> - drop tty argument form handle_sysrq()") from the input tree which
> (despite not mentioning this) changed an "int" argument to "bool" but
> neglected to include linux/types.h.
> 
> I added this patch for today:

Thank you very much for the patch. I folded it into original patch to
avoid build failures in case someone needs to bisect.

-- 
Dmitry

linux-next: build failure after merge of the final tree (input tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]

Hi Dmitry,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/input/touchscreen/wacom_w8001.c: In function 'w8001_setup':
drivers/input/touchscreen/wacom_w8001.c:287: error: implicit declaration of function 'mdelay'

Caused by commit b8fe15cb1b435928f9967d660e925fe7afb32787 ("Input:
wacom_w8001 - support pen or touch only devices").  See Rule 1 in
Documentation/SubmitChecklist.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (input tree related)

[Dmitry Torokhov]

On Wed, Dec 29, 2010 at 12:51:29PM +1100, Stephen Rothwell wrote:
> Hi Dmitry,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/input/touchscreen/wacom_w8001.c: In function 'w8001_setup':
> drivers/input/touchscreen/wacom_w8001.c:287: error: implicit declaration of function 'mdelay'
> 
> Caused by commit b8fe15cb1b435928f9967d660e925fe7afb32787 ("Input:
> wacom_w8001 - support pen or touch only devices").  See Rule 1 in
> Documentation/SubmitChecklist.
> 
> I have reverted that commit for today.

Thank you Stephen, I'll fix this up in my tree.

-- 
Dmitry

Re: linux-next: build failure after merge of the final tree (input tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1097 bytes --]

Hi Dmitry,

On Tue, 28 Dec 2010 18:34:58 -0800 Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>
> On Wed, Dec 29, 2010 at 12:51:29PM +1100, Stephen Rothwell wrote:
> > 
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> > 
> > drivers/input/touchscreen/wacom_w8001.c: In function 'w8001_setup':
> > drivers/input/touchscreen/wacom_w8001.c:287: error: implicit declaration of function 'mdelay'
> > 
> > Caused by commit b8fe15cb1b435928f9967d660e925fe7afb32787 ("Input:
> > wacom_w8001 - support pen or touch only devices").  See Rule 1 in
> > Documentation/SubmitChecklist.
> > 
> > I have reverted that commit for today.
> 
> Thank you Stephen, I'll fix this up in my tree.

I note that this commit has been redone in your tree (as commit
11a862ed9f04558e222fa15a5fbd76698fed11ff) but there have been no changes
to it at all (except the commit date).

I have reverted that commit from today's linux-next.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (input tree related)

[Ping Cheng]

On Wed, Dec 29, 2010 at 3:51 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Dmitry,
>
> On Tue, 28 Dec 2010 18:34:58 -0800 Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>>
>> On Wed, Dec 29, 2010 at 12:51:29PM +1100, Stephen Rothwell wrote:
>> >
>> > After merging the final tree, today's linux-next build (powerpc
>> > allyesconfig) failed like this:
>> >
>> > drivers/input/touchscreen/wacom_w8001.c: In function 'w8001_setup':
>> > drivers/input/touchscreen/wacom_w8001.c:287: error: implicit declaration of function 'mdelay'
>> >
>> > Caused by commit b8fe15cb1b435928f9967d660e925fe7afb32787 ("Input:
>> > wacom_w8001 - support pen or touch only devices").  See Rule 1 in
>> > Documentation/SubmitChecklist.

I do not see the error on my testing systems somehow. Does adding the
following line resolve the issue?

#include < include/linux/delay.h>

Ping

>> > I have reverted that commit for today.
>>
>> Thank you Stephen, I'll fix this up in my tree.
>
> I note that this commit has been redone in your tree (as commit
> 11a862ed9f04558e222fa15a5fbd76698fed11ff) but there have been no changes
> to it at all (except the commit date).
>
> I have reverted that commit from today's linux-next.
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
>

Re: linux-next: build failure after merge of the final tree (input tree related)

[Geert Uytterhoeven]

On Thu, Dec 30, 2010 at 19:06, Ping Cheng <pinglinux@gmail.com> wrote:
> On Wed, Dec 29, 2010 at 3:51 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> On Tue, 28 Dec 2010 18:34:58 -0800 Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>>> On Wed, Dec 29, 2010 at 12:51:29PM +1100, Stephen Rothwell wrote:
>>> > After merging the final tree, today's linux-next build (powerpc
>>> > allyesconfig) failed like this:
>>> >
>>> > drivers/input/touchscreen/wacom_w8001.c: In function 'w8001_setup':
>>> > drivers/input/touchscreen/wacom_w8001.c:287: error: implicit declaration of function 'mdelay'
>>> >
>>> > Caused by commit b8fe15cb1b435928f9967d660e925fe7afb32787 ("Input:
>>> > wacom_w8001 - support pen or touch only devices").  See Rule 1 in
>>> > Documentation/SubmitChecklist.
>
> I do not see the error on my testing systems somehow. Does adding the
> following line resolve the issue?
>
> #include < include/linux/delay.h>

"#include <linux/delay.h>", I assume?

>>> > I have reverted that commit for today.
>>>
>>> Thank you Stephen, I'll fix this up in my tree.
>>
>> I note that this commit has been redone in your tree (as commit
>> 11a862ed9f04558e222fa15a5fbd76698fed11ff) but there have been no changes
>> to it at all (except the commit date).
>>
>> I have reverted that commit from today's linux-next.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: linux-next: build failure after merge of the final tree (input tree related)

[Ping Cheng]

On Thu, Dec 30, 2010 at 11:58 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Thu, Dec 30, 2010 at 19:06, Ping Cheng <pinglinux@gmail.com> wrote:
>> On Wed, Dec 29, 2010 at 3:51 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>> On Tue, 28 Dec 2010 18:34:58 -0800 Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>>>> On Wed, Dec 29, 2010 at 12:51:29PM +1100, Stephen Rothwell wrote:
>>>> > After merging the final tree, today's linux-next build (powerpc
>>>> > allyesconfig) failed like this:
>>>> >
>>>> > drivers/input/touchscreen/wacom_w8001.c: In function 'w8001_setup':
>>>> > drivers/input/touchscreen/wacom_w8001.c:287: error: implicit declaration of function 'mdelay'
>>>> >
>>>> > Caused by commit b8fe15cb1b435928f9967d660e925fe7afb32787 ("Input:
>>>> > wacom_w8001 - support pen or touch only devices").  See Rule 1 in
>>>> > Documentation/SubmitChecklist.
>>
>> I do not see the error on my testing systems somehow. Does adding the
>> following line resolve the issue?
>>
>> #include < include/linux/delay.h>
>
> "#include <linux/delay.h>", I assume?

You are right. Take it as a typo or copy/paste error ;).

Ping

Re: linux-next: build failure after merge of the final tree (input tree related)

[Dmitry Torokhov]

On Thu, Dec 30, 2010 at 10:51:30AM +1100, Stephen Rothwell wrote:
> Hi Dmitry,
> 
> On Tue, 28 Dec 2010 18:34:58 -0800 Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> >
> > On Wed, Dec 29, 2010 at 12:51:29PM +1100, Stephen Rothwell wrote:
> > > 
> > > After merging the final tree, today's linux-next build (powerpc
> > > allyesconfig) failed like this:
> > > 
> > > drivers/input/touchscreen/wacom_w8001.c: In function 'w8001_setup':
> > > drivers/input/touchscreen/wacom_w8001.c:287: error: implicit declaration of function 'mdelay'
> > > 
> > > Caused by commit b8fe15cb1b435928f9967d660e925fe7afb32787 ("Input:
> > > wacom_w8001 - support pen or touch only devices").  See Rule 1 in
> > > Documentation/SubmitChecklist.
> > > 
> > > I have reverted that commit for today.
> > 
> > Thank you Stephen, I'll fix this up in my tree.
> 
> I note that this commit has been redone in your tree (as commit
> 11a862ed9f04558e222fa15a5fbd76698fed11ff) but there have been no changes
> to it at all (except the commit date).
> 

Gah, I forgot to do 'git add' before doing 'git commit --amend', should
be better now.

-- 
Dmitry

linux-next: build failure after merge of the final tree (input tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2253 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc allyesconfig)
failed like this:

drivers/input/keyboard/gpio_keys.c: In function 'gpio_keys_get_devtree_pdata':
drivers/input/keyboard/gpio_keys.c:500:3: warning: passing argument 3 of 'of_property_read_u32' from incompatible pointer type
include/linux/of.h:268:19: note: expected 'u32 *' but argument is of type 'const u32 **'
drivers/input/keyboard/gpio_keys.c:504:19: warning: assignment makes integer from pointer without a cast
drivers/input/keyboard/gpio_keys.c:508:3: warning: passing argument 3 of 'of_property_read_u32' from incompatible pointer type
include/linux/of.h:268:19: note: expected 'u32 *' but argument is of type 'const u32 **'
drivers/input/keyboard/gpio_keys.c:509:20: warning: assignment makes integer from pointer without a cast
drivers/input/keyboard/gpio_keys.c:515:3: warning: passing argument 3 of 'of_property_read_u32' from incompatible pointer type
include/linux/of.h:268:19: note: expected 'u32 *' but argument is of type 'const u32 **'
drivers/input/keyboard/gpio_keys.c:516:33: warning: assignment makes integer from pointer without a cast
drivers/input/keyboard/gpio_keys.c:502:4: error: label 'out_fail' used but not defined
drivers/input/keyboard/gpio_keys.c: At top level:
drivers/input/keyboard/gpio_keys.c:523:7: error: expected '=', ',', ';', 'asm' or '__attribute__' before '->' token
drivers/input/keyboard/gpio_keys.c:525:2: error: expected identifier or '(' before 'return'
drivers/input/keyboard/gpio_keys.c:527:9: error: expected '=', ',', ';', 'asm' or '__attribute__' before ':' token
drivers/input/keyboard/gpio_keys.c:529:2: error: expected identifier or '(' before 'return'
drivers/input/keyboard/gpio_keys.c:530:1: error: expected identifier or '(' before '}' token
drivers/input/keyboard/gpio_keys.c: In function 'gpio_keys_get_devtree_pdata':
drivers/input/keyboard/gpio_keys.c:521:2: warning: control reaches end of non-void function

Caused by commit d6ba97c9806b ("Input: gpio_keys - use
of_property_read_u32()").  Mostly by a brace mismatch.


I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (input tree related)

[Tobias Klauser]

On 2011-09-19 at 10:46:21 +0200, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc allyesconfig)
> failed like this:
> 
> drivers/input/keyboard/gpio_keys.c: In function 'gpio_keys_get_devtree_pdata':
> drivers/input/keyboard/gpio_keys.c:500:3: warning: passing argument 3 of 'of_property_read_u32' from incompatible pointer type
> include/linux/of.h:268:19: note: expected 'u32 *' but argument is of type 'const u32 **'
> drivers/input/keyboard/gpio_keys.c:504:19: warning: assignment makes integer from pointer without a cast
> drivers/input/keyboard/gpio_keys.c:508:3: warning: passing argument 3 of 'of_property_read_u32' from incompatible pointer type
> include/linux/of.h:268:19: note: expected 'u32 *' but argument is of type 'const u32 **'
> drivers/input/keyboard/gpio_keys.c:509:20: warning: assignment makes integer from pointer without a cast
> drivers/input/keyboard/gpio_keys.c:515:3: warning: passing argument 3 of 'of_property_read_u32' from incompatible pointer type
> include/linux/of.h:268:19: note: expected 'u32 *' but argument is of type 'const u32 **'
> drivers/input/keyboard/gpio_keys.c:516:33: warning: assignment makes integer from pointer without a cast
> drivers/input/keyboard/gpio_keys.c:502:4: error: label 'out_fail' used but not defined
> drivers/input/keyboard/gpio_keys.c: At top level:
> drivers/input/keyboard/gpio_keys.c:523:7: error: expected '=', ',', ';', 'asm' or '__attribute__' before '->' token
> drivers/input/keyboard/gpio_keys.c:525:2: error: expected identifier or '(' before 'return'
> drivers/input/keyboard/gpio_keys.c:527:9: error: expected '=', ',', ';', 'asm' or '__attribute__' before ':' token
> drivers/input/keyboard/gpio_keys.c:529:2: error: expected identifier or '(' before 'return'
> drivers/input/keyboard/gpio_keys.c:530:1: error: expected identifier or '(' before '}' token
> drivers/input/keyboard/gpio_keys.c: In function 'gpio_keys_get_devtree_pdata':
> drivers/input/keyboard/gpio_keys.c:521:2: warning: control reaches end of non-void function
> 
> Caused by commit d6ba97c9806b ("Input: gpio_keys - use
> of_property_read_u32()").  Mostly by a brace mismatch.

Sorry, my fault. I thought I compile-tested this but obviously didn't.
I'll send an updated patch to Dmitry.

Tobias