From: Ingo Molnar <mingo@elte.hu>
To: David Miller <davem@davemloft.net>
Cc: sfr@canb.auug.org.au, tglx@linutronix.de, hpa@zytor.com,
peterz@infradead.org, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, fweisbec@gmail.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: linux-next: PowerPC WARN_ON_ONCE() after merge of the final tree (tip related)
Date: Thu, 15 Apr 2010 09:32:56 +0200 [thread overview]
Message-ID: <20100415073256.GG9240@elte.hu> (raw)
In-Reply-To: <20100414.235557.123118153.davem@davemloft.net>
* David Miller <davem@davemloft.net> wrote:
> From: Ingo Molnar <mingo@elte.hu>
> Date: Thu, 15 Apr 2010 08:49:40 +0200
>
> > Btw., WARN_ON trapping on PowerPC is clearly a PowerPC bug - there's a good
> > reason we have WARN_ON versus BUG_ON - it should be fixed.
>
> I disagree, an implementation should be allowed to use the most
> efficient implementation possible for both interfaces.
It trades robustness for slightly better space/code efficiency.
Such a trap based mechanism exists on x86 as well and we use it for BUG_ON().
We intentionally dont use it to generate warnings and dont override __WARN(),
because it would blow up way too often when a warning triggers in some
sensitive codepath that cannot take a trap.
Anyway, the warning obviously has to be fixed - but the boot crash itself is
PowerPC's own doing.
Ingo
next prev parent reply other threads:[~2010-04-15 7:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 6:12 linux-next: boot failure after merge of the final tree (tip related) Stephen Rothwell
2010-04-15 6:48 ` Benjamin Herrenschmidt
2010-04-15 6:49 ` linux-next: PowerPC WARN_ON_ONCE() " Ingo Molnar
2010-04-15 6:55 ` David Miller
2010-04-15 7:32 ` Ingo Molnar [this message]
2010-04-16 1:51 ` Benjamin Herrenschmidt
2010-04-16 1:56 ` Benjamin Herrenschmidt
2010-04-15 10:04 ` Stephen Rothwell
2010-04-15 13:00 ` Frederic Weisbecker
2010-04-15 14:03 ` Ingo Molnar
2010-04-15 17:15 ` Frederic Weisbecker
2010-04-16 10:38 ` Peter Zijlstra
2010-04-16 12:32 ` Frederic Weisbecker
2010-04-15 17:24 ` Frederic Weisbecker
2010-04-15 17:39 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100415073256.GG9240@elte.hu \
--to=mingo@elte.hu \
--cc=davem@davemloft.net \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).