linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: April 27 (wireless/libertas warnings)
@ 2010-04-27 15:36 Randy Dunlap
  2010-04-27 15:59 ` John W. Linville
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2010-04-27 15:36 UTC (permalink / raw)
  To: Linux Kernel Mailing List,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-next

drivers/net/wireless/libertas_tf/deb_defs.h:12:1: warning: "pr_fmt" redefined
include/linux/kernel.h:376:1: warning: this is the location of the previous definition
drivers/net/wireless/libertas_tf/deb_defs.h:12:1: warning: "pr_fmt" redefined
include/linux/kernel.h:376:1: warning: this is the location of the previous definition

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: linux-next: April 27 (wireless/libertas warnings)
  2010-04-27 15:36 linux-next: April 27 (wireless/libertas warnings) Randy Dunlap
@ 2010-04-27 15:59 ` John W. Linville
  0 siblings, 0 replies; 2+ messages in thread
From: John W. Linville @ 2010-04-27 15:59 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: Linux Kernel Mailing List, linux-wireless@vger.kernel.org,
	linux-next, Steve deRosier

On Tue, Apr 27, 2010 at 08:36:37AM -0700, Randy Dunlap wrote:
> drivers/net/wireless/libertas_tf/deb_defs.h:12:1: warning: "pr_fmt" redefined
> include/linux/kernel.h:376:1: warning: this is the location of the previous definition
> drivers/net/wireless/libertas_tf/deb_defs.h:12:1: warning: "pr_fmt" redefined
> include/linux/kernel.h:376:1: warning: this is the location of the previous definition

Yup, just had this exchange w/ Stephen...

The problem comes from including slab.h before deb_defs.h (as done
in linux-next).  The version in wireless-testing avoids the warning
by including the headers in the other order, but that is a bit ugly.

Does anyone know if it is OK to #undef pr_fmt before defining it
in deb_defs.h?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-04-27 16:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-27 15:36 linux-next: April 27 (wireless/libertas warnings) Randy Dunlap
2010-04-27 15:59 ` John W. Linville

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).