linux-next: build failure after merge of the final tree (usb tree related)

linux-next: build failure after merge of the final tree (usb tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1303 bytes --]

Hi Greg,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/usb/otg/twl4030-usb.c: In function 'twl4030_usb_set_bits':
drivers/usb/otg/twl4030-usb.c:238: error: implicit declaration of function 'ULPI_SET'
drivers/usb/otg/twl4030-usb.c: In function 'twl4030_usb_clear_bits':
drivers/usb/otg/twl4030-usb.c:244: error: implicit declaration of function 'ULPI_CLR'
drivers/usb/otg/twl4030-usb.c: In function 'twl4030_usb_set_mode':
drivers/usb/otg/twl4030-usb.c:303: error: 'ULPI_IFC_CTRL' undeclared (first use in this function)
drivers/usb/otg/twl4030-usb.c:304: error: 'ULPI_IFC_CTRL_CARKITMODE' undeclared (first use in this function)
drivers/usb/otg/twl4030-usb.c:306: error: 'ULPI_FUNC_CTRL' undeclared (first use in this function)
drivers/usb/otg/twl4030-usb.c:307: error: 'ULPI_FUNC_CTRL_XCVRSEL_MASK' undeclared (first use in this function)
drivers/usb/otg/twl4030-usb.c:308: error: 'ULPI_FUNC_CTRL_OPMODE_MASK' undeclared (first use in this function)

Caused by commit 57983872ff14cba23d6404a40c89e52063c94854 ("usb: otg:
twl4030: use the global ULPI register definitions").  I have reverted
that commit for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build failure after merge of the final tree (usb tree related)

[Heikki Krogerus]

Hi,

On Fri, Apr 30, 2010 at 08:05:55AM +0200, ext Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/usb/otg/twl4030-usb.c: In function 'twl4030_usb_set_bits':
> drivers/usb/otg/twl4030-usb.c:238: error: implicit declaration of function 'ULPI_SET'
> drivers/usb/otg/twl4030-usb.c: In function 'twl4030_usb_clear_bits':
> drivers/usb/otg/twl4030-usb.c:244: error: implicit declaration of function 'ULPI_CLR'
> drivers/usb/otg/twl4030-usb.c: In function 'twl4030_usb_set_mode':
> drivers/usb/otg/twl4030-usb.c:303: error: 'ULPI_IFC_CTRL' undeclared (first use in this function)
> drivers/usb/otg/twl4030-usb.c:304: error: 'ULPI_IFC_CTRL_CARKITMODE' undeclared (first use in this function)
> drivers/usb/otg/twl4030-usb.c:306: error: 'ULPI_FUNC_CTRL' undeclared (first use in this function)
> drivers/usb/otg/twl4030-usb.c:307: error: 'ULPI_FUNC_CTRL_XCVRSEL_MASK' undeclared (first use in this function)
> drivers/usb/otg/twl4030-usb.c:308: error: 'ULPI_FUNC_CTRL_OPMODE_MASK' undeclared (first use in this function)
> 
> Caused by commit 57983872ff14cba23d6404a40c89e52063c94854 ("usb: otg:
> twl4030: use the global ULPI register definitions").  I have reverted
> that commit for today.

Already informed Greg that he needs the patch for the global ulpi
registers before this one.

-- 
heikki

Re: linux-next: build failure after merge of the final tree (usb tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1676 bytes --]

Hi Guys,

On Fri, 30 Apr 2010 09:22:24 +0300 Heikki Krogerus <ext-heikki.krogerus@nokia.com> wrote:
>
> On Fri, Apr 30, 2010 at 08:05:55AM +0200, ext Stephen Rothwell wrote:
> > 
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> > 
> > drivers/usb/otg/twl4030-usb.c: In function 'twl4030_usb_set_bits':
> > drivers/usb/otg/twl4030-usb.c:238: error: implicit declaration of function 'ULPI_SET'
> > drivers/usb/otg/twl4030-usb.c: In function 'twl4030_usb_clear_bits':
> > drivers/usb/otg/twl4030-usb.c:244: error: implicit declaration of function 'ULPI_CLR'
> > drivers/usb/otg/twl4030-usb.c: In function 'twl4030_usb_set_mode':
> > drivers/usb/otg/twl4030-usb.c:303: error: 'ULPI_IFC_CTRL' undeclared (first use in this function)
> > drivers/usb/otg/twl4030-usb.c:304: error: 'ULPI_IFC_CTRL_CARKITMODE' undeclared (first use in this function)
> > drivers/usb/otg/twl4030-usb.c:306: error: 'ULPI_FUNC_CTRL' undeclared (first use in this function)
> > drivers/usb/otg/twl4030-usb.c:307: error: 'ULPI_FUNC_CTRL_XCVRSEL_MASK' undeclared (first use in this function)
> > drivers/usb/otg/twl4030-usb.c:308: error: 'ULPI_FUNC_CTRL_OPMODE_MASK' undeclared (first use in this function)
> > 
> > Caused by commit 57983872ff14cba23d6404a40c89e52063c94854 ("usb: otg:
> > twl4030: use the global ULPI register definitions").  I have reverted
> > that commit for today.
> 
> Already informed Greg that he needs the patch for the global ulpi
> registers before this one.

Still got this one today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build failure after merge of the final tree (usb tree related)

[Greg KH]

On Mon, May 03, 2010 at 02:57:15PM +1000, Stephen Rothwell wrote:
> Hi Guys,
> 
> On Fri, 30 Apr 2010 09:22:24 +0300 Heikki Krogerus <ext-heikki.krogerus@nokia.com> wrote:
> >
> > On Fri, Apr 30, 2010 at 08:05:55AM +0200, ext Stephen Rothwell wrote:
> > > 
> > > After merging the final tree, today's linux-next build (powerpc
> > > allyesconfig) failed like this:
> > > 
> > > drivers/usb/otg/twl4030-usb.c: In function 'twl4030_usb_set_bits':
> > > drivers/usb/otg/twl4030-usb.c:238: error: implicit declaration of function 'ULPI_SET'
> > > drivers/usb/otg/twl4030-usb.c: In function 'twl4030_usb_clear_bits':
> > > drivers/usb/otg/twl4030-usb.c:244: error: implicit declaration of function 'ULPI_CLR'
> > > drivers/usb/otg/twl4030-usb.c: In function 'twl4030_usb_set_mode':
> > > drivers/usb/otg/twl4030-usb.c:303: error: 'ULPI_IFC_CTRL' undeclared (first use in this function)
> > > drivers/usb/otg/twl4030-usb.c:304: error: 'ULPI_IFC_CTRL_CARKITMODE' undeclared (first use in this function)
> > > drivers/usb/otg/twl4030-usb.c:306: error: 'ULPI_FUNC_CTRL' undeclared (first use in this function)
> > > drivers/usb/otg/twl4030-usb.c:307: error: 'ULPI_FUNC_CTRL_XCVRSEL_MASK' undeclared (first use in this function)
> > > drivers/usb/otg/twl4030-usb.c:308: error: 'ULPI_FUNC_CTRL_OPMODE_MASK' undeclared (first use in this function)
> > > 
> > > Caused by commit 57983872ff14cba23d6404a40c89e52063c94854 ("usb: otg:
> > > twl4030: use the global ULPI register definitions").  I have reverted
> > > that commit for today.
> > 
> > Already informed Greg that he needs the patch for the global ulpi
> > registers before this one.
> 
> Still got this one today.

Yes, I need the patch from Heikki...  {hint...}

thanks,

greg k-h

Re: linux-next: build failure after merge of the final tree (usb tree related)

[Greg KH]

On Mon, May 03, 2010 at 10:13:48AM -0700, Greg KH wrote:
> On Mon, May 03, 2010 at 02:57:15PM +1000, Stephen Rothwell wrote:
> > Hi Guys,
> > 
> > On Fri, 30 Apr 2010 09:22:24 +0300 Heikki Krogerus <ext-heikki.krogerus@nokia.com> wrote:
> > >
> > > On Fri, Apr 30, 2010 at 08:05:55AM +0200, ext Stephen Rothwell wrote:
> > > > 
> > > > After merging the final tree, today's linux-next build (powerpc
> > > > allyesconfig) failed like this:
> > > > 
> > > > drivers/usb/otg/twl4030-usb.c: In function 'twl4030_usb_set_bits':
> > > > drivers/usb/otg/twl4030-usb.c:238: error: implicit declaration of function 'ULPI_SET'
> > > > drivers/usb/otg/twl4030-usb.c: In function 'twl4030_usb_clear_bits':
> > > > drivers/usb/otg/twl4030-usb.c:244: error: implicit declaration of function 'ULPI_CLR'
> > > > drivers/usb/otg/twl4030-usb.c: In function 'twl4030_usb_set_mode':
> > > > drivers/usb/otg/twl4030-usb.c:303: error: 'ULPI_IFC_CTRL' undeclared (first use in this function)
> > > > drivers/usb/otg/twl4030-usb.c:304: error: 'ULPI_IFC_CTRL_CARKITMODE' undeclared (first use in this function)
> > > > drivers/usb/otg/twl4030-usb.c:306: error: 'ULPI_FUNC_CTRL' undeclared (first use in this function)
> > > > drivers/usb/otg/twl4030-usb.c:307: error: 'ULPI_FUNC_CTRL_XCVRSEL_MASK' undeclared (first use in this function)
> > > > drivers/usb/otg/twl4030-usb.c:308: error: 'ULPI_FUNC_CTRL_OPMODE_MASK' undeclared (first use in this function)
> > > > 
> > > > Caused by commit 57983872ff14cba23d6404a40c89e52063c94854 ("usb: otg:
> > > > twl4030: use the global ULPI register definitions").  I have reverted
> > > > that commit for today.
> > > 
> > > Already informed Greg that he needs the patch for the global ulpi
> > > registers before this one.
> > 
> > Still got this one today.
> 
> Yes, I need the patch from Heikki...  {hint...}

Oh nevermind, I see them now, stupid me.  I'll go queue them up.

thanks,

greg k-h

Re: linux-next: build failure after merge of the final tree (usb tree related)

[Greg KH]

On Mon, May 03, 2010 at 10:35:01AM -0700, Greg KH wrote:
> On Mon, May 03, 2010 at 10:13:48AM -0700, Greg KH wrote:
> > On Mon, May 03, 2010 at 02:57:15PM +1000, Stephen Rothwell wrote:
> > > Hi Guys,
> > > 
> > > On Fri, 30 Apr 2010 09:22:24 +0300 Heikki Krogerus <ext-heikki.krogerus@nokia.com> wrote:
> > > >
> > > > On Fri, Apr 30, 2010 at 08:05:55AM +0200, ext Stephen Rothwell wrote:
> > > > > 
> > > > > After merging the final tree, today's linux-next build (powerpc
> > > > > allyesconfig) failed like this:
> > > > > 
> > > > > drivers/usb/otg/twl4030-usb.c: In function 'twl4030_usb_set_bits':
> > > > > drivers/usb/otg/twl4030-usb.c:238: error: implicit declaration of function 'ULPI_SET'
> > > > > drivers/usb/otg/twl4030-usb.c: In function 'twl4030_usb_clear_bits':
> > > > > drivers/usb/otg/twl4030-usb.c:244: error: implicit declaration of function 'ULPI_CLR'
> > > > > drivers/usb/otg/twl4030-usb.c: In function 'twl4030_usb_set_mode':
> > > > > drivers/usb/otg/twl4030-usb.c:303: error: 'ULPI_IFC_CTRL' undeclared (first use in this function)
> > > > > drivers/usb/otg/twl4030-usb.c:304: error: 'ULPI_IFC_CTRL_CARKITMODE' undeclared (first use in this function)
> > > > > drivers/usb/otg/twl4030-usb.c:306: error: 'ULPI_FUNC_CTRL' undeclared (first use in this function)
> > > > > drivers/usb/otg/twl4030-usb.c:307: error: 'ULPI_FUNC_CTRL_XCVRSEL_MASK' undeclared (first use in this function)
> > > > > drivers/usb/otg/twl4030-usb.c:308: error: 'ULPI_FUNC_CTRL_OPMODE_MASK' undeclared (first use in this function)
> > > > > 
> > > > > Caused by commit 57983872ff14cba23d6404a40c89e52063c94854 ("usb: otg:
> > > > > twl4030: use the global ULPI register definitions").  I have reverted
> > > > > that commit for today.
> > > > 
> > > > Already informed Greg that he needs the patch for the global ulpi
> > > > registers before this one.
> > > 
> > > Still got this one today.
> > 
> > Yes, I need the patch from Heikki...  {hint...}
> 
> Oh nevermind, I see them now, stupid me.  I'll go queue them up.

This should now be resolved.

thanks,

greg k-h

Re: linux-next: build failure after merge of the final tree (usb tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

Hi Greg,

On Mon, 3 May 2010 11:02:57 -0700 Greg KH <greg@kroah.com> wrote:
>
> This should now be resolved.

Great, thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

linux-next: build failure after merge of the final tree (usb tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]

Hi Greg,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

In file included from drivers/usb/host/ehci-hcd.c:113:
drivers/usb/host/ehci-dbg.c: In function 'debug_lpm_write':
drivers/usb/host/ehci-dbg.c:992: error: implicit declaration of function 'copy_from_user'

Caused by commit a3c0b4b257eeaefe4e6c8fbf5ddfe674242f1b9e ("USB: EHCI:
EHCI 1.1 addendum: preparation").  Presumably a missing include of
linux/uaccess.h ...

I applied this patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 17 Jun 2010 14:49:09 +1000
Subject: [PATCH] usb: using copy_from_user in ehci-hcd requies the include of uaccess.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/usb/host/ehci-hcd.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
index 40928fe..8697ad1 100644
--- a/drivers/usb/host/ehci-hcd.c
+++ b/drivers/usb/host/ehci-hcd.c
@@ -36,6 +36,7 @@
 #include <linux/dma-mapping.h>
 #include <linux/debugfs.h>
 #include <linux/slab.h>
+#include <linux/uaccess.h>
 
 #include <asm/byteorder.h>
 #include <asm/io.h>
-- 
1.7.1


-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build failure after merge of the final tree (usb tree related)

[Greg KH]

On Thu, Jun 17, 2010 at 02:53:31PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> In file included from drivers/usb/host/ehci-hcd.c:113:
> drivers/usb/host/ehci-dbg.c: In function 'debug_lpm_write':
> drivers/usb/host/ehci-dbg.c:992: error: implicit declaration of function 'copy_from_user'
> 
> Caused by commit a3c0b4b257eeaefe4e6c8fbf5ddfe674242f1b9e ("USB: EHCI:
> EHCI 1.1 addendum: preparation").  Presumably a missing include of
> linux/uaccess.h ...
> 
> I applied this patch for today:

thanks, I've merged your fix in with the main patch so this problem will
not show up, and pushed the updated patches out.

thanks,

greg k-h

Re: linux-next: build failure after merge of the final tree (usb tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

Hi Greg,

On Thu, 17 Jun 2010 10:25:16 -0700 Greg KH <greg@kroah.com> wrote:
>
> thanks, I've merged your fix in with the main patch so this problem will
> not show up, and pushed the updated patches out.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

linux-next: build failure after merge of the final tree (usb tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 602 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

In file included from drivers/usb/host/ohci-hcd.c:1165:0:
drivers/usb/host/ohci-sm501.c: In function 'ohci_sm501_resume':
drivers/usb/host/ohci-sm501.c:241:2: error: implicit declaration of function 'ohci_finish_controller_resume' [-Werror=implicit-function-declaration]

Caused by commit cfa49b4b88fe ("USB: ohci: merge
ohci_finish_controller_resume with ohci_resume").

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (usb tree related)

[Greg KH]

On Tue, Oct 23, 2012 at 03:13:54PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> In file included from drivers/usb/host/ohci-hcd.c:1165:0:
> drivers/usb/host/ohci-sm501.c: In function 'ohci_sm501_resume':
> drivers/usb/host/ohci-sm501.c:241:2: error: implicit declaration of function 'ohci_finish_controller_resume' [-Werror=implicit-function-declaration]
> 
> Caused by commit cfa49b4b88fe ("USB: ohci: merge
> ohci_finish_controller_resume with ohci_resume").

Ick.  Florian, can you send me a fix-up patch for this?

thanks,

greg k-h