linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>, gregkh@suse.de
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	devel@driverdev.osuosl.org
Subject: [PATCH -next] staging/rar_register: depends on PCI
Date: Wed, 5 May 2010 15:45:22 -0700	[thread overview]
Message-ID: <20100505154522.c3d7807c.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20100505123409.ed5678a2.sfr@canb.auug.org.au>

From: Randy Dunlap <randy.dunlap@oracle.com>

rar_register driver uses PCI interfaces and PCI devices, so it
should depend on PCI.

Also format the Kconfig help text as normally done.

drivers/staging/rar_register/rar_register.c:623: error: implicit declaration of function 'pci_dev_get'
drivers/staging/rar_register/rar_register.c:623: warning: assignment makes pointer from integer without a cast

Note:  The memrar driver selects this driver's Kconfig symbol, even when
PCI is not enabled.  That select could be changed to
	select RAR_REGISTER if PCI
but that would still result in build errors when PCI is not enabled, namely:
drivers/built-in.o: In function `memrar_fini_rar_resources':
memrar_handler.c:(.text+0x2391b7): undefined reference to `unregister_rar'
drivers/built-in.o: In function `memrar_registration_callback':
memrar_handler.c:(.text+0x23925a): undefined reference to `rar_get_address'
drivers/built-in.o: In function `memrar_init':
memrar_handler.c:(.init.text+0x12c7b): undefined reference to `register_rar'
memrar_handler.c:(.init.text+0x12c97): undefined reference to `register_rar'

Does anyone have suggestions for this?

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/staging/rar_register/Kconfig |   28 ++++++++++++-------------
 1 file changed, 14 insertions(+), 14 deletions(-)

--- linux-next-20100505.orig/drivers/staging/rar_register/Kconfig
+++ linux-next-20100505/drivers/staging/rar_register/Kconfig
@@ -8,23 +8,23 @@ menu "RAR Register Driver"
 #
 config RAR_REGISTER
 	tristate "Restricted Access Region Register Driver"
+	depends on PCI
 	default n
 	---help---
-		This driver allows other kernel drivers access to the
-		contents of the restricted access region control
-		registers.
+	  This driver allows other kernel drivers access to the
+	  contents of the restricted access region control registers.
 
-		The restricted access region control registers
-		(rar_registers) are used to pass address and
-		locking information on restricted access regions
-		to other drivers that use restricted access regions
+	  The restricted access region control registers
+	  (rar_registers) are used to pass address and
+	  locking information on restricted access regions
+	  to other drivers that use restricted access regions.
 
-		The restricted access regions are regions of memory
-		on the Intel MID Platform that are not accessible to
-		the x86 processor, but are accessible to dedicated
-		processors on board peripheral devices.
+	  The restricted access regions are regions of memory
+	  on the Intel MID Platform that are not accessible to
+	  the x86 processor, but are accessible to dedicated
+	  processors on board peripheral devices.
 
-		The purpose of the restricted access regions is to
-		protect sensitive data from compromise by unauthorized
-		programs running on the x86 processor.
+	  The purpose of the restricted access regions is to
+	  protect sensitive data from compromise by unauthorized
+	  programs running on the x86 processor.
 endmenu

  parent reply	other threads:[~2010-05-05 22:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-05  2:34 linux-next: Tree for May 5 Stephen Rothwell
2010-05-05 22:44 ` [PATCH -next] media: fix vivi build error Randy Dunlap
2010-05-05 22:45 ` Randy Dunlap [this message]
2010-05-05 23:55   ` [PATCH -next] staging/rar_register: depends on PCI Alan Cox
2010-05-06  2:32     ` Randy Dunlap
2010-05-05 22:46 ` [PATCH -next] usb gadget webcam: depends on VIDEO_DEV Randy Dunlap
2010-05-06  7:57   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100505154522.c3d7807c.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).