From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Brown Subject: Re: linux-next: build failure after merge of the staging-next tree Date: Tue, 18 May 2010 15:30:20 +1000 Message-ID: <20100518153020.06d5a602@notabene.brown> References: <20100430155205.a4171034.sfr@canb.auug.org.au> <20100430144340.GD1824@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from cantor2.suse.de ([195.135.220.15]:57095 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756066Ab0ERFad (ORCPT ); Tue, 18 May 2010 01:30:33 -0400 In-Reply-To: <20100430144340.GD1824@kroah.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Greg KH Cc: Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, "Eric W. Biederman" , Benjamin Thery On Fri, 30 Apr 2010 07:43:40 -0700 Greg KH wrote: > On Fri, Apr 30, 2010 at 03:52:05PM +1000, Stephen Rothwell wrote: > > Hi Greg, > > > > After merging the staging-next tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > drivers/md/md.c: In function 'level_store': > > drivers/md/md.c:3029: error: too few arguments to function 'sysfs_get_dirent' > > > > Caused by commit 262f8e4937e7b4a587923ca3c039a184668f49ec ("sysfs: > > Implement sysfs tagged directory support") from the driver-core tree > > interacting with commit fecc531e3cc0de60514d326c7d82f1075ed55888 ("md: > > manage redundancy group in sysfs when changing level") from the md. > > > > I have applied this fixup patch for today and can carry it as necessary. > > > > [This could have been avoided, of course, by creating a new API (maybe > > sysfs_get_dirent_tagged) and implementing the old API in terms of that]. > > Thanks for the fixup. hi Greg, I'm assuming that you will submit you patch queue to Linus first, then I will create a merge which fixes this issue and ask Linus to pull that - so everything is all still bisectable without me rebasing. If you are OK with that, please let me know when you have submitted your queue.. I'll try to keep and eye open, but I might miss it... Thanks, NeilBrown