From: "John W. Linville" <linville@tuxdriver.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-wireless@vger.kernel.org, linux-next@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
reinette.chatre@intel.com
Subject: Re: linux-next: Tree for June 3 (iwlwifi)
Date: Thu, 3 Jun 2010 13:21:15 -0400 [thread overview]
Message-ID: <20100603172114.GA14597@tuxdriver.com> (raw)
In-Reply-To: <20100603085501.ac113779.randy.dunlap@oracle.com>
On Thu, Jun 03, 2010 at 08:55:01AM -0700, Randy Dunlap wrote:
> On Thu, 3 Jun 2010 13:47:53 +1000 Stephen Rothwell wrote:
>
> > Hi all,
> >
> > Changes since 20100602:
>
>
> when CONFIG_IWLAGN=n:
>
> drivers/net/wireless/iwlwifi/iwl-rx.c:254: error: 'struct iwl_priv' has no member named '_agn'
> drivers/net/wireless/iwlwifi/iwl-rx.c:303: error: 'struct iwl_priv' has no member named '_agn'
> drivers/net/wireless/iwlwifi/iwl-rx.c:304: error: 'struct iwl_priv' has no member named '_agn'
> drivers/net/wireless/iwlwifi/iwl-rx.c:305: error: 'struct iwl_priv' has no member named '_agn'
> drivers/net/wireless/iwlwifi/iwl-rx.c:306: error: 'struct iwl_priv' has no member named '_agn'
>
> and many more.
>
> Haven't we seen this movie before?
Ugh...caused be this:
commit a2064b7a4a22d118087898e4308670da7ac07911
Author: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Date: Fri Apr 30 14:21:48 2010 -0700
iwlwifi: move _agn statistics related structure
agn and 3945 has different statistics_notif data structure; since 3945
has it statistics_notif data structure inside the _3945 portion of
iwl_priv, it make sense to move the agn statistics_notif into _agn portion.
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Since iwl-rx.o is part of iwlcore.ko, this change seems wrong.
Reinette, any reason why I shouldn't just revert it?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-06-03 17:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 3:47 linux-next: Tree for June 3 Stephen Rothwell
2010-06-03 7:39 ` Dave Young
2010-06-03 8:00 ` Dave Young
2010-06-03 8:16 ` Dave Young
2010-06-03 12:52 ` Rusty Russell
2010-06-04 19:46 ` Tony Luck
2010-06-04 20:04 ` Linus Torvalds
2010-06-04 20:46 ` Luck, Tony
2010-06-04 22:05 ` Linus Torvalds
2010-06-04 22:50 ` Luck, Tony
2010-06-04 22:57 ` Linus Torvalds
2010-06-05 2:39 ` Rusty Russell
2010-06-05 2:51 ` Rusty Russell
2010-06-05 4:01 ` Rusty Russell
2010-06-07 18:16 ` Luck, Tony
2010-06-03 15:46 ` linux-next: Tree for June 3 (qlcnic) Randy Dunlap
2010-06-03 17:31 ` Anirban Chakraborty
[not found] ` <20100603134753.710a64b3.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2010-06-03 15:55 ` linux-next: Tree for June 3 (iwlwifi) Randy Dunlap
2010-06-03 17:21 ` John W. Linville [this message]
[not found] ` <20100603172114.GA14597-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2010-06-03 17:42 ` Guy, Wey-Yi
2010-06-03 17:45 ` reinette chatre
2010-06-03 16:39 ` [PATCH -next] classmate-laptop: fix for RFKILL=m, CMPC=y Randy Dunlap
2010-06-09 20:02 ` Thadeu Lima de Souza Cascardo
2010-06-09 20:05 ` Randy Dunlap
2010-06-09 20:11 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100603172114.GA14597@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=reinette.chatre@intel.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).