From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: [PATCH 2/2 -next] niu: always include of_device.h Date: Wed, 9 Jun 2010 15:44:09 -0700 Message-ID: <20100609154409.bf024c0c.randy.dunlap@oracle.com> References: <20100609133443.38f1f957.sfr@canb.auug.org.au> <20100609103657.66252a27.randy.dunlap@oracle.com> <20100609.110638.112605100.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from rcsinet10.oracle.com ([148.87.113.121]:33278 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757409Ab0FIWpQ (ORCPT ); Wed, 9 Jun 2010 18:45:16 -0400 In-Reply-To: <20100609.110638.112605100.davem@davemloft.net> Sender: linux-next-owner@vger.kernel.org List-ID: To: David Miller , Grant Likely Cc: sfr@canb.auug.org.au, netdev@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org From: Randy Dunlap The niu driver uses struct of_device when built on any arch, not only SPARC64, so always #include . drivers/net/niu.c:9700: warning: 'struct of_device' declared inside parameter list drivers/net/niu.c:9700: warning: its scope is only this definition or declaration, which is probably not what you want drivers/net/niu.c:9716: warning: assignment from incompatible pointer type Signed-off-by: Randy Dunlap Cc: Grant Likely Cc: Dave Miller --- drivers/net/niu.c | 3 --- 1 file changed, 3 deletions(-) --- linux-next-20100609.orig/drivers/net/niu.c +++ linux-next-20100609/drivers/net/niu.c @@ -28,10 +28,7 @@ #include #include - -#ifdef CONFIG_SPARC64 #include -#endif #include "niu.h"