From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: linux-next: Tree for June 11 Date: Tue, 15 Jun 2010 18:56:37 +0930 Message-ID: <201006151856.38882.rusty@rustcorp.com.au> References: <20100611141738.cf8a6bbf.sfr@canb.auug.org.au> <20100611163124.bbc01d34.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from ozlabs.org ([203.10.76.45]:60880 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751443Ab0FOJ0m (ORCPT ); Tue, 15 Jun 2010 05:26:42 -0400 In-Reply-To: <20100611163124.bbc01d34.akpm@linux-foundation.org> Sender: linux-next-owner@vger.kernel.org List-ID: To: Andrew Morton Cc: Stephen Rothwell , linux-next@vger.kernel.org, LKML On Sat, 12 Jun 2010 09:01:24 am Andrew Morton wrote: > On Fri, 11 Jun 2010 14:17:38 +1000 > Stephen Rothwell wrote: > > > I have created today's linux-next tree at > > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > (patches at http://www.kernel.org/pub/linux/kernel/v2.6/next/ ). > > Rusty broke your kernel! > > oops: http://userweb.kernel.org/~akpm/IMG_20100611_155611.jpg > > config: http://userweb.kernel.org/~akpm/stuff/config-akpm2-small.txt > > (gdb) l *0xffffffff8105f9fb > 0xffffffff8105f9fb is in get_ksymbol (kernel/module.c:2784). > 2779 if (mod->symtab[i].st_shndx == SHN_UNDEF) > 2780 continue; > 2781 > 2782 /* We ignore unnamed symbols: they're uninformative > 2783 * and inserted at a whim. */ > 2784 if (mod->symtab[i].st_value <= addr > 2785 && mod->symtab[i].st_value > mod->symtab[best].st_value > 2786 && *(mod->strtab + mod->symtab[i].st_name) != '\0' > 2787 && !is_arm_mapping_symbol(mod->strtab + mod->symtab[i].st_name)) > 2788 best = i; Hmm, I can't reproduce this :( I'm only 32 bit here, have to dig out my 64-bit machine tomorrow. One wonders why we're in get_ksymbol at all. Has something already gone horribly wrong? Rusty.