From: Rusty Russell <rusty@rustcorp.com.au>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
linux-next@vger.kernel.org, Corey Minyard <minyard@acm.org>
Subject: Re: [PATCH -next] ipmi: fix module param sparse warnings
Date: Mon, 28 Jun 2010 19:05:58 +0930 [thread overview]
Message-ID: <201006281905.59387.rusty@rustcorp.com.au> (raw)
In-Reply-To: <4C24D779.6020209@oracle.com>
On Sat, 26 Jun 2010 01:51:13 am Randy Dunlap wrote:
> On 06/25/10 05:50, Rusty Russell wrote:
> > On Fri, 25 Jun 2010 07:51:22 am Randy Dunlap wrote:
> >> From: Randy Dunlap <randy.dunlap@oracle.com>
> >>
> >> The <arg> parameter in module_param_cb() should be a pointer,
> >
> > Well, I don't think there's anything wrong with it being a function.
>
> Ah, yes, I see. That makes it a sparse error, right?
Well, it's a weird corner case, but yes.
> > Meanwhile, we can do this instead. Does it solve it as well?
>
> Yes, that also fixes it.
> Thanks.
Thanks, I've added your tested-by.
Cheers,
Rusty.
prev parent reply other threads:[~2010-06-28 9:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 22:21 [PATCH -next] ipmi: fix module param sparse warnings Randy Dunlap
2010-06-25 12:50 ` Rusty Russell
2010-06-25 16:21 ` Randy Dunlap
2010-06-28 9:35 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006281905.59387.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=minyard@acm.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).