From: Christoph Hellwig <hch@lst.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Alex Elder <aelder@sgi.com>,
xfs-masters@oss.sgi.com, linux-next@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
Dave Chinner <dchinner@redhat.com>,
Randy Dunlap <randy.dunlap@oracle.com>
Subject: Re: [PATCH] Fix xfs build when CONFIG_XFS_POSIX_ACL=n
Date: Thu, 15 Jul 2010 20:00:38 +0200 [thread overview]
Message-ID: <20100715180038.GA1396@lst.de> (raw)
In-Reply-To: <4c3f42cf1240489af5@agluck-desktop.sc.intel.com>
On Thu, Jul 15, 2010 at 10:18:07AM -0700, Luck, Tony wrote:
> When CONFIG_XFS_POSIX_ACL is not set "xfs_check_acl" is #defined
> to NULL - which breaks the code attempting to add a tracepoint
> on this function.
>
> Only define the tracepoint when the function exists.
>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
Thanks, that's much better than the stubbing changes I had prepared.
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2010-07-15 18:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 17:18 [PATCH] Fix xfs build when CONFIG_XFS_POSIX_ACL=n Luck, Tony
2010-07-15 18:00 ` Christoph Hellwig [this message]
2010-07-15 18:06 ` Randy Dunlap
2010-07-26 15:48 ` Randy Dunlap
2010-07-28 14:22 ` Alex Elder
2010-07-28 17:25 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100715180038.GA1396@lst.de \
--to=hch@lst.de \
--cc=aelder@sgi.com \
--cc=dchinner@redhat.com \
--cc=linux-next@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=tony.luck@intel.com \
--cc=xfs-masters@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).