From: Andrew Morton <akpm@linux-foundation.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Christoph Hellwig <hch@lst.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Eric Van Hensbergen <ericvh@gmail.com>,
Sripathi Kodi <sripathik@in.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-next@vger.kernel.org
Subject: Re: remove inode_setattr
Date: Tue, 10 Aug 2010 17:59:44 -0700 [thread overview]
Message-ID: <20100810175944.5919319e.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100811005216.GB31363@ZenIV.linux.org.uk>
On Wed, 11 Aug 2010 01:52:16 +0100
Al Viro <viro@ZenIV.linux.org.uk> wrote:
> Whiskey Tango Fotrot, Over
>
> In Linus' tree we have
> commit 1025774ce411f2bd4b059ad7b53f0003569b74fa
> Author: Christoph Hellwig <hch@lst.de>
> Date: Fri Jun 4 11:30:02 2010 +0200
> ...
> diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
> index 4331b3b..4b3ad6a 100644
> --- a/fs/9p/vfs_inode.c
> +++ b/fs/9p/vfs_inode.c
> @@ -896,10 +896,19 @@ static int v9fs_vfs_setattr(struct dentry *dentry, struct
> }
>
> retval = p9_client_wstat(fid, &wstat);
> - if (retval >= 0)
> - retval = inode_setattr(dentry->d_inode, iattr);
> + if (retval < 0)
> + return retval;
> +
> + if ((iattr->ia_valid & ATTR_SIZE) &&
> + iattr->ia_size != i_size_read(dentry->d_inode)) {
> + retval = vmtruncate(dentry->d_inode, iattr->ia_size);
> + if (retval)
> + return retval;
> + }
>
> So what the hell is going on?
That's v9fs_vfs_setattr(). The problem is in the new
v9fs_vfs_setattr_dotl().
next prev parent reply other threads:[~2010-08-11 1:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201008101859.o7AIx9BM026915@hera.kernel.org>
[not found] ` <20100810155011.b9657102.akpm@linux-foundation.org>
[not found] ` <20100811101751.1afdded8.sfr@canb.auug.org.au>
2010-08-11 0:45 ` remove inode_setattr Stephen Rothwell
2010-08-11 0:52 ` Al Viro
2010-08-11 0:59 ` Andrew Morton [this message]
2010-08-11 1:01 ` Al Viro
2010-08-11 1:00 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100810175944.5919319e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ericvh@gmail.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=sripathik@in.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).