From: Samuel Ortiz <sameo@linux.intel.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] mfd: tps6586x depends on GPIOLIB
Date: Wed, 11 Aug 2010 01:14:22 +0200 [thread overview]
Message-ID: <20100810231421.GA2571@sortiz-mobl> (raw)
In-Reply-To: <20100810094059.c320b916.randy.dunlap@oracle.com>
On Tue, Aug 10, 2010 at 09:40:59AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> tps6586x uses gpio interfaces, so it should depend on GPIOLIB.
Thanks Randy, I merged this one into the yet to be pulled tps6586x driver.
Cheers,
Samuel.
> Fixes these build errors:
>
> drivers/mfd/tps6586x.c:41: error: field 'gpio' has incomplete type
> drivers/mfd/tps6586x.c:195: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/mfd/tps6586x.c:195: warning: initialization from incompatible pointer type
> drivers/mfd/tps6586x.c:210: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/mfd/tps6586x.c:210: warning: initialization from incompatible pointer type
> drivers/mfd/tps6586x.c:219: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/mfd/tps6586x.c:219: warning: initialization from incompatible pointer type
> drivers/mfd/tps6586x.c:249: error: implicit declaration of function 'gpiochip_add'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> ---
> drivers/mfd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20100810.orig/drivers/mfd/Kconfig
> +++ linux-next-20100810/drivers/mfd/Kconfig
> @@ -543,7 +543,7 @@ config MFD_JZ4740_ADC
>
> config MFD_TPS6586X
> tristate "TPS6586x Power Management chips"
> - depends on I2C
> + depends on I2C && GPIOLIB
> select MFD_CORE
> help
> If you say yes here you get support for the TPS6586X series of
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2010-08-10 23:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-10 3:56 linux-next: Tree for August 10 Stephen Rothwell
2010-08-10 9:56 ` Alan Cox
2010-08-10 16:40 ` [PATCH -next] mfd: tps6586x depends on GPIOLIB Randy Dunlap
2010-08-10 23:14 ` Samuel Ortiz [this message]
2010-08-10 17:02 ` linux-next: Tree for August 10 (acpi/apei) Randy Dunlap
2010-08-11 1:32 ` Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100810231421.GA2571@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).