linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: build failure after merge of the final tree (input tree related)
@ 2010-08-20  3:12 Stephen Rothwell
  2010-08-21  7:39 ` Dmitry Torokhov
  0 siblings, 1 reply; 13+ messages in thread
From: Stephen Rothwell @ 2010-08-20  3:12 UTC (permalink / raw)
  To: Dmitry Torokhov
  Cc: linux-next, linux-kernel, Alan Cox, Jason Wessel,
	Greg Kroah-Hartman

Hi Dmitry,

After merging the final tree, today's linux-next build (i386 defconfig)
failed like this:

In file included from drivers/gpu/drm/i915/i915_irq.c:29:
include/linux/sysrq.h:45: error: expected declaration specifiers or '...' before 'bool'

Caused by commit a821bafce37b26499e2bfbf2e6b96b0636efc014 ("Input: sysrq
- drop tty argument form handle_sysrq()") from the input tree which
(despite not mentioning this) changed an "int" argument to "bool" but
neglected to include linux/types.h.

I added this patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 20 Aug 2010 13:06:30 +1000
Subject: [PATCH] input: using bool in sysrq.h requires including types.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/linux/sysrq.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/sysrq.h b/include/linux/sysrq.h
index 32d360a..387fa7d 100644
--- a/include/linux/sysrq.h
+++ b/include/linux/sysrq.h
@@ -15,6 +15,7 @@
 #define _LINUX_SYSRQ_H
 
 #include <linux/errno.h>
+#include <linux/types.h>
 
 /* Possible values of bitmask for enabling sysrq functions */
 /* 0x0001 is reserved for enable everything */
-- 
1.7.1

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

^ permalink raw reply related	[flat|nested] 13+ messages in thread
* linux-next: build failure after merge of the final tree (input tree related)
@ 2011-09-19  8:46 Stephen Rothwell
  2011-09-19  9:01 ` Tobias Klauser
  0 siblings, 1 reply; 13+ messages in thread
From: Stephen Rothwell @ 2011-09-19  8:46 UTC (permalink / raw)
  To: Dmitry Torokhov; +Cc: linux-next, linux-kernel, Tobias Klauser

[-- Attachment #1: Type: text/plain, Size: 2253 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc allyesconfig)
failed like this:

drivers/input/keyboard/gpio_keys.c: In function 'gpio_keys_get_devtree_pdata':
drivers/input/keyboard/gpio_keys.c:500:3: warning: passing argument 3 of 'of_property_read_u32' from incompatible pointer type
include/linux/of.h:268:19: note: expected 'u32 *' but argument is of type 'const u32 **'
drivers/input/keyboard/gpio_keys.c:504:19: warning: assignment makes integer from pointer without a cast
drivers/input/keyboard/gpio_keys.c:508:3: warning: passing argument 3 of 'of_property_read_u32' from incompatible pointer type
include/linux/of.h:268:19: note: expected 'u32 *' but argument is of type 'const u32 **'
drivers/input/keyboard/gpio_keys.c:509:20: warning: assignment makes integer from pointer without a cast
drivers/input/keyboard/gpio_keys.c:515:3: warning: passing argument 3 of 'of_property_read_u32' from incompatible pointer type
include/linux/of.h:268:19: note: expected 'u32 *' but argument is of type 'const u32 **'
drivers/input/keyboard/gpio_keys.c:516:33: warning: assignment makes integer from pointer without a cast
drivers/input/keyboard/gpio_keys.c:502:4: error: label 'out_fail' used but not defined
drivers/input/keyboard/gpio_keys.c: At top level:
drivers/input/keyboard/gpio_keys.c:523:7: error: expected '=', ',', ';', 'asm' or '__attribute__' before '->' token
drivers/input/keyboard/gpio_keys.c:525:2: error: expected identifier or '(' before 'return'
drivers/input/keyboard/gpio_keys.c:527:9: error: expected '=', ',', ';', 'asm' or '__attribute__' before ':' token
drivers/input/keyboard/gpio_keys.c:529:2: error: expected identifier or '(' before 'return'
drivers/input/keyboard/gpio_keys.c:530:1: error: expected identifier or '(' before '}' token
drivers/input/keyboard/gpio_keys.c: In function 'gpio_keys_get_devtree_pdata':
drivers/input/keyboard/gpio_keys.c:521:2: warning: control reaches end of non-void function

Caused by commit d6ba97c9806b ("Input: gpio_keys - use
of_property_read_u32()").  Mostly by a brace mismatch.


I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread
* linux-next: build failure after merge of the final tree (input tree related)
@ 2010-12-29  1:51 Stephen Rothwell
  2010-12-29  2:34 ` Dmitry Torokhov
  0 siblings, 1 reply; 13+ messages in thread
From: Stephen Rothwell @ 2010-12-29  1:51 UTC (permalink / raw)
  To: Dmitry Torokhov; +Cc: linux-next, linux-kernel, Ping Cheng

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]

Hi Dmitry,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/input/touchscreen/wacom_w8001.c: In function 'w8001_setup':
drivers/input/touchscreen/wacom_w8001.c:287: error: implicit declaration of function 'mdelay'

Caused by commit b8fe15cb1b435928f9967d660e925fe7afb32787 ("Input:
wacom_w8001 - support pen or touch only devices").  See Rule 1 in
Documentation/SubmitChecklist.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread
* linux-next: build failure after merge of the final tree (input tree related)
@ 2010-03-23  6:54 Stephen Rothwell
  2010-03-23  7:31 ` Dmitry Torokhov
  0 siblings, 1 reply; 13+ messages in thread
From: Stephen Rothwell @ 2010-03-23  6:54 UTC (permalink / raw)
  To: Dmitry Torokhov; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1803 bytes --]

Hi Dmitry,

After merging the final tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

drivers/built-in.o: In function `sysrq_filter':
sysrq.c:(.text+0x224da): undefined reference to `fg_console'
sysrq.c:(.text+0x224e2): undefined reference to `fg_console'
sysrq.c:(.text+0x224f2): undefined reference to `vc_cons'
sysrq.c:(.text+0x224f6): undefined reference to `vc_cons'
drivers/built-in.o: In function `sysrq_disconnect':
sysrq.c:(.text+0x226e4): undefined reference to `input_close_device'
sysrq.c:(.text+0x226ec): undefined reference to `input_unregister_handle'
drivers/built-in.o: In function `sysrq_connect':
sysrq.c:(.text+0x22780): undefined reference to `input_register_handle'
sysrq.c:(.text+0x22790): undefined reference to `input_open_device'
sysrq.c:(.text+0x227f0): undefined reference to `input_unregister_handle'
drivers/built-in.o: In function `sysrq_toggle_support':
(.text+0x22b6c): undefined reference to `input_unregister_handler'
drivers/built-in.o: In function `sysrq_toggle_support':
(.text+0x22bac): undefined reference to `input_register_handler'
drivers/built-in.o: In function `sysrq_init':
sysrq.c:(.init.text+0x18d4): undefined reference to `input_register_handler'

Caused by commit edc6e384f9d96e54a6d03068d3b03fa5b56b6449 ("Input:
implement SysRq as a separate input handler").  This build does not have
CONFIG_HW_CONSOLE or CONFIG_INPUT set, but does have CONFIG_MAGIC_SYSRQ
set to 'y'.

For today, I have reverted that commit, commit
75394b382f16feddac9c523abf0eca8346afcf23 ("Input: keyboard - fix
formatting issues") which conflicted with the revert and the merge fixup
patch for the kgdb tree..

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread
end of thread, other threads:[~2011-09-19  9:01 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-20  3:12 linux-next: build failure after merge of the final tree (input tree related) Stephen Rothwell
2010-08-21  7:39 ` Dmitry Torokhov
  -- strict thread matches above, loose matches on Subject: below --
2011-09-19  8:46 Stephen Rothwell
2011-09-19  9:01 ` Tobias Klauser
2010-12-29  1:51 Stephen Rothwell
2010-12-29  2:34 ` Dmitry Torokhov
2010-12-29 23:51   ` Stephen Rothwell
2010-12-30 18:06     ` Ping Cheng
2010-12-30 19:58       ` Geert Uytterhoeven
2010-12-30 20:10         ` Ping Cheng
2011-01-02  8:05     ` Dmitry Torokhov
2010-03-23  6:54 Stephen Rothwell
2010-03-23  7:31 ` Dmitry Torokhov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).