Re: [PATCH -next] optprobes: fix kconfig depends/selects

[Randy Dunlap <randy.dunlap@oracle.com>]

On Sun, 12 Sep 2010 21:41:07 +0300 Felipe Contreras wrote:

> On Sun, Sep 12, 2010 at 9:34 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > On 09/12/10 03:49, Felipe Contreras wrote:
> >> On Thu, Aug 12, 2010 at 10:26 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> >>> From: Randy Dunlap <randy.dunlap@oracle.com>
> >>>
> >>> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency.
> >>> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL.
> >>>
> >>> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)
> >>>
> >>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> >>> Cc:     Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> >>> Cc:     Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
> >>> Cc:     "David S. Miller" <davem@davemloft.net>
> >>> Cc:     Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> >>> ---
> >>>  arch/Kconfig |    2 ++
> >>>  1 file changed, 2 insertions(+)
> >>>
> >>> --- linux-next-20100810.orig/arch/Kconfig
> >>> +++ linux-next-20100810/arch/Kconfig
> >>> @@ -45,6 +45,8 @@ config OPTPROBES
> >>>        def_bool y
> >>>        depends on KPROBES && HAVE_OPTPROBES
> >>>        depends on !PREEMPT
> >>> +       depends on DEBUG_KERNEL
> >>> +       select KALLSYMS
> >>>        select KALLSYMS_ALL
> >>>
> >>>  config HAVE_EFFICIENT_UNALIGNED_ACCESS
> >>> --
> >>
> >> This causes another problem:
> >>
> >> arch/Kconfig:33:error: recursive dependency detected!
> >> arch/Kconfig:33:      symbol KPROBES depends on KALLSYMS
> >> init/Kconfig:825:     symbol KALLSYMS is selected by OPTPROBES
> >> arch/Kconfig:44:      symbol OPTPROBES depends on KPROBES
> >>
> >> The 'select KALLSYMS' is redundant.
> >>
> >> Otherwise: Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> >
> > Thanks for checking.  I saw this problem just a day or two ago myself.
> >
> > Dropping the select does not eliminate the kconfig warning.
> > I'll try something else.
> 
> Huh? The original warning is gone by just adding 'depends on DEBUG_KERNEL'.

not so in my testing.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***