From: Arnd Bergmann <arnd@arndb.de>
To: Roland Dreier <rdreier@cisco.com>
Cc: Steve Wise <swise@opengridcomputing.com>,
linux-rdma@vger.kernel.org, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/cxgb4: Add default_llseek to debugfs files.
Date: Wed, 29 Sep 2010 21:29:31 +0200 [thread overview]
Message-ID: <201009292129.31415.arnd@arndb.de> (raw)
In-Reply-To: <ada4od82w5x.fsf@cisco.com>
On Wednesday 29 September 2010 21:21:14 Roland Dreier wrote:
>
> > The main difference between default_llseek and generic_file_llseek
> > is that default_llseek doesn't care about the maximum file size
> > of the underlying file system, which is ULONG_MAX on debugfs,
> > so they are equivalent.
>
> I thought default_llseek also takes the BKL still?
Not any more in linux-next.
> > In general, the preferred one is no_llseek for those files where
> > you know you do not need to seek. If you do, I'd use default_llseek
> > for character devices and generic_file_llseek for file systems
> > that set the s_maxbytes.
>
> The case in question is for debugfs files, so we should use
> generic_file_llseek, right?
Yes, but it's a very weak "should". My automatic conversion script
uses default_llseek.
Arnd
next prev parent reply other threads:[~2010-09-29 19:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 14:11 [PATCH] RDMA/cxgb4: Add default_llseek to debugfs files Steve Wise
[not found] ` <20100929141112.26944.21931.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org>
2010-09-29 17:19 ` Roland Dreier
[not found] ` <adawrq431sr.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2010-09-29 17:27 ` Steve Wise
2010-09-29 17:41 ` Roland Dreier
2010-09-29 17:49 ` Steve Wise
2010-09-29 17:50 ` Roland Dreier
2010-09-29 19:17 ` Arnd Bergmann
[not found] ` <201009292117.54828.arnd-r2nGTMty4D4@public.gmane.org>
2010-09-29 19:21 ` Roland Dreier
2010-09-29 19:29 ` Arnd Bergmann [this message]
2010-09-29 19:40 ` Roland Dreier
2010-09-29 18:52 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009292129.31415.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).