linux-next: build failure after merge of the final tree (mmc tree related)

linux-next: build failure after merge of the final tree (mmc tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1383 bytes --]

Hi Chris,

After merging the scsi-post-merge tree, today's linux-next build ()
failed like this:

drivers/mmc/host/sdhci-of-esdhc.c:21:25: error: sdhci-esdhc.c: No such file or directory
drivers/mmc/host/sdhci-of-esdhc.c: In function 'esdhc_writeb':
drivers/mmc/host/sdhci-of-esdhc.c:51: error: 'ESDHC_HOST_CONTROL_RES' undeclared (first use in this function)
drivers/mmc/host/sdhci-of-esdhc.c:51: error: (Each undeclared identifier is reported only once
drivers/mmc/host/sdhci-of-esdhc.c:51: error: for each function it appears in.)
drivers/mmc/host/sdhci-of-esdhc.c: In function 'esdhc_of_enable_dma':
drivers/mmc/host/sdhci-of-esdhc.c:57: error: 'ESDHC_DMA_SYSCTL' undeclared (first use in this function)
drivers/mmc/host/sdhci-of-esdhc.c:57: error: 'ESDHC_DMA_SNOOP' undeclared (first use in this function)
drivers/mmc/host/sdhci-of-esdhc.c: At top level:
drivers/mmc/host/sdhci-of-esdhc.c:76: error: 'ESDHC_DEFAULT_QUIRKS' undeclared here (not in a function)
drivers/mmc/host/sdhci-of-esdhc.c:84: error: 'esdhc_set_clock' undeclared here (not in a function)

Caused by commit a2fe088a5aaa51b54c018cf309cdc728d5f4e540 ("mmc:
sdhci-of-esdhc: factor out common stuff").

This was clearly never build tested ...

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (mmc tree related)

[Chris Ball]

Hi Stephen,

On Mon, Oct 18, 2010 at 06:35:40PM +1100, Stephen Rothwell wrote:
> After merging the scsi-post-merge tree, today's linux-next build ()
> failed like this:
[...] 
> Caused by commit a2fe088a5aaa51b54c018cf309cdc728d5f4e540 ("mmc:
> sdhci-of-esdhc: factor out common stuff").
> 
> This was clearly never build tested ...
> 
> I have reverted that commit for today.

Sorry about this -- you're right, my test compile missed this patch.
I've pushed a tested fix now.

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

linux-next: build failure after merge of the final tree (mmc tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 5638 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/mmc/host/sdhci-of-hlwd.o: In function `sdhci_pltfm_register':
(.opd+0xd8): multiple definition of `sdhci_pltfm_register'
drivers/mmc/host/sdhci-of-esdhc.o:(.opd+0xd8): first defined here
drivers/mmc/host/sdhci-of-hlwd.o: In function `.sdhci_pltfm_init':
(.text+0x568): multiple definition of `.sdhci_pltfm_init'
drivers/mmc/host/sdhci-of-esdhc.o:(.text+0x568): first defined here
drivers/mmc/host/sdhci-of-hlwd.o: In function `.sdhci_get_of_property':
(.text+0x34c): multiple definition of `.sdhci_get_of_property'
drivers/mmc/host/sdhci-of-esdhc.o:(.text+0x34c): first defined here
drivers/mmc/host/sdhci-of-hlwd.o: In function `.sdhci_be32bs_writel':
(.text+0x13c): multiple definition of `.sdhci_be32bs_writel'
drivers/mmc/host/sdhci-of-esdhc.o:(.text+0x13c): first defined here
drivers/mmc/host/sdhci-of-hlwd.o: In function `sdhci_pltfm_resume':
(.opd+0x120): multiple definition of `sdhci_pltfm_resume'
drivers/mmc/host/sdhci-of-esdhc.o:(.opd+0x120): first defined here
drivers/mmc/host/sdhci-of-hlwd.o: In function `sdhci_be32bs_readl':
(.opd+0x0): multiple definition of `sdhci_be32bs_readl'
drivers/mmc/host/sdhci-of-esdhc.o:(.opd+0x0): first defined here
drivers/mmc/host/sdhci-of-hlwd.o: In function `.sdhci_be32bs_readw':
(.text+0x64): multiple definition of `.sdhci_be32bs_readw'
drivers/mmc/host/sdhci-of-esdhc.o:(.text+0x64): first defined here
drivers/mmc/host/sdhci-of-hlwd.o: In function `.sdhci_pltfm_free':
(.text+0x8d0): multiple definition of `.sdhci_pltfm_free'
drivers/mmc/host/sdhci-of-esdhc.o:(.text+0x8d0): first defined here
drivers/mmc/host/sdhci-of-hlwd.o: In function `sdhci_pltfm_free':
(.opd+0xc0): multiple definition of `sdhci_pltfm_free'
drivers/mmc/host/sdhci-of-esdhc.o:(.opd+0xc0): first defined here
drivers/mmc/host/sdhci-of-hlwd.o: In function `sdhci_be32bs_readw':
(.opd+0x18): multiple definition of `sdhci_be32bs_readw'
drivers/mmc/host/sdhci-of-esdhc.o:(.opd+0x18): first defined here
drivers/mmc/host/sdhci-of-hlwd.o: In function `.sdhci_pltfm_unregister':
(.text+0xa94): multiple definition of `.sdhci_pltfm_unregister'
drivers/mmc/host/sdhci-of-esdhc.o:(.text+0xa94): first defined here
drivers/mmc/host/sdhci-of-hlwd.o: In function `.sdhci_be32bs_readb':
(.text+0xd0): multiple definition of `.sdhci_be32bs_readb'
drivers/mmc/host/sdhci-of-esdhc.o:(.text+0xd0): first defined here
drivers/mmc/host/sdhci-of-hlwd.o: In function `.sdhci_be32bs_writew':
(.text+0x1a0): multiple definition of `.sdhci_be32bs_writew'
drivers/mmc/host/sdhci-of-esdhc.o:(.text+0x1a0): first defined here
drivers/mmc/host/sdhci-of-hlwd.o: In function `sdhci_be32bs_writel':
(.opd+0x48): multiple definition of `sdhci_be32bs_writel'
drivers/mmc/host/sdhci-of-esdhc.o:(.opd+0x48): first defined here
drivers/mmc/host/sdhci-of-hlwd.o: In function `sdhci_pltfm_unregister':
(.opd+0xf0): multiple definition of `sdhci_pltfm_unregister'
drivers/mmc/host/sdhci-of-esdhc.o:(.opd+0xf0): first defined here
drivers/mmc/host/sdhci-of-hlwd.o: In function `sdhci_be32bs_writew':
(.opd+0x60): multiple definition of `sdhci_be32bs_writew'
drivers/mmc/host/sdhci-of-esdhc.o:(.opd+0x60): first defined here
drivers/mmc/host/sdhci-of-hlwd.o: In function `.sdhci_pltfm_resume':
(.text+0xc70): multiple definition of `.sdhci_pltfm_resume'
drivers/mmc/host/sdhci-of-esdhc.o:(.text+0xc70): first defined here
drivers/mmc/host/sdhci-of-hlwd.o: In function `.sdhci_be32bs_writeb':
(.text+0x2ac): multiple definition of `.sdhci_be32bs_writeb'
drivers/mmc/host/sdhci-of-esdhc.o:(.text+0x2ac): first defined here
drivers/mmc/host/sdhci-of-hlwd.o: In function `.sdhci_pltfm_suspend':
(.text+0xc04): multiple definition of `.sdhci_pltfm_suspend'
drivers/mmc/host/sdhci-of-esdhc.o:(.text+0xc04): first defined here
drivers/mmc/host/sdhci-of-hlwd.o: In function `.sdhci_pltfm_register':
(.text+0x9c0): multiple definition of `.sdhci_pltfm_register'
drivers/mmc/host/sdhci-of-esdhc.o:(.text+0x9c0): first defined here
drivers/mmc/host/sdhci-of-hlwd.o: In function `.sdhci_be32bs_readl':
(.text+0x0): multiple definition of `.sdhci_be32bs_readl'
drivers/mmc/host/sdhci-of-esdhc.o:(.text+0x0): first defined here
drivers/mmc/host/sdhci-of-hlwd.o: In function `sdhci_be32bs_writeb':
(.opd+0x78): multiple definition of `sdhci_be32bs_writeb'
drivers/mmc/host/sdhci-of-esdhc.o:(.opd+0x78): first defined here
drivers/mmc/host/sdhci-of-hlwd.o: In function `sdhci_pltfm_suspend':
(.opd+0x108): multiple definition of `sdhci_pltfm_suspend'
drivers/mmc/host/sdhci-of-esdhc.o:(.opd+0x108): first defined here
drivers/mmc/host/sdhci-of-hlwd.o: In function `sdhci_get_of_property':
(.opd+0x90): multiple definition of `sdhci_get_of_property'
drivers/mmc/host/sdhci-of-esdhc.o:(.opd+0x90): first defined here
drivers/mmc/host/sdhci-of-hlwd.o: In function `sdhci_pltfm_init':
(.opd+0xa8): multiple definition of `sdhci_pltfm_init'
drivers/mmc/host/sdhci-of-esdhc.o:(.opd+0xa8): first defined here
drivers/mmc/host/sdhci-of-hlwd.o: In function `sdhci_be32bs_readb':
(.opd+0x30): multiple definition of `sdhci_be32bs_readb'
drivers/mmc/host/sdhci-of-esdhc.o:(.opd+0x30): first defined here

Presumably caused by commit e2d0d7dc5542 ("mmc: sdhci: make sdhci-of
device drivers self registered").

I have reverted the merge of the mmc tree for today.

P.S. Chris, some commits in your tree have no SoB from you despite the
fact that you committed them.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (mmc tree related)

[Shawn Guo]

Hi Stephen,

On Wed, Jun 01, 2011 at 01:04:31PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/mmc/host/sdhci-of-hlwd.o: In function `sdhci_pltfm_register':
> (.opd+0xd8): multiple definition of `sdhci_pltfm_register'
> drivers/mmc/host/sdhci-of-esdhc.o:(.opd+0xd8): first defined here
> drivers/mmc/host/sdhci-of-hlwd.o: In function `.sdhci_pltfm_init':
> (.text+0x568): multiple definition of `.sdhci_pltfm_init'
> drivers/mmc/host/sdhci-of-esdhc.o:(.text+0x568): first defined here
> drivers/mmc/host/sdhci-of-hlwd.o: In function `.sdhci_get_of_property':
> (.text+0x34c): multiple definition of `.sdhci_get_of_property'
> drivers/mmc/host/sdhci-of-esdhc.o:(.text+0x34c): first defined here
> drivers/mmc/host/sdhci-of-hlwd.o: In function `.sdhci_be32bs_writel':
> (.text+0x13c): multiple definition of `.sdhci_be32bs_writel'
> drivers/mmc/host/sdhci-of-esdhc.o:(.text+0x13c): first defined here
> drivers/mmc/host/sdhci-of-hlwd.o: In function `sdhci_pltfm_resume':
> (.opd+0x120): multiple definition of `sdhci_pltfm_resume'
> drivers/mmc/host/sdhci-of-esdhc.o:(.opd+0x120): first defined here
> drivers/mmc/host/sdhci-of-hlwd.o: In function `sdhci_be32bs_readl':
> (.opd+0x0): multiple definition of `sdhci_be32bs_readl'
> drivers/mmc/host/sdhci-of-esdhc.o:(.opd+0x0): first defined here
> drivers/mmc/host/sdhci-of-hlwd.o: In function `.sdhci_be32bs_readw':
> (.text+0x64): multiple definition of `.sdhci_be32bs_readw'
> drivers/mmc/host/sdhci-of-esdhc.o:(.text+0x64): first defined here
> drivers/mmc/host/sdhci-of-hlwd.o: In function `.sdhci_pltfm_free':
> (.text+0x8d0): multiple definition of `.sdhci_pltfm_free'
> drivers/mmc/host/sdhci-of-esdhc.o:(.text+0x8d0): first defined here
> drivers/mmc/host/sdhci-of-hlwd.o: In function `sdhci_pltfm_free':
> (.opd+0xc0): multiple definition of `sdhci_pltfm_free'
> drivers/mmc/host/sdhci-of-esdhc.o:(.opd+0xc0): first defined here
> drivers/mmc/host/sdhci-of-hlwd.o: In function `sdhci_be32bs_readw':
> (.opd+0x18): multiple definition of `sdhci_be32bs_readw'
> drivers/mmc/host/sdhci-of-esdhc.o:(.opd+0x18): first defined here
> drivers/mmc/host/sdhci-of-hlwd.o: In function `.sdhci_pltfm_unregister':
> (.text+0xa94): multiple definition of `.sdhci_pltfm_unregister'
> drivers/mmc/host/sdhci-of-esdhc.o:(.text+0xa94): first defined here
> drivers/mmc/host/sdhci-of-hlwd.o: In function `.sdhci_be32bs_readb':
> (.text+0xd0): multiple definition of `.sdhci_be32bs_readb'
> drivers/mmc/host/sdhci-of-esdhc.o:(.text+0xd0): first defined here
> drivers/mmc/host/sdhci-of-hlwd.o: In function `.sdhci_be32bs_writew':
> (.text+0x1a0): multiple definition of `.sdhci_be32bs_writew'
> drivers/mmc/host/sdhci-of-esdhc.o:(.text+0x1a0): first defined here
> drivers/mmc/host/sdhci-of-hlwd.o: In function `sdhci_be32bs_writel':
> (.opd+0x48): multiple definition of `sdhci_be32bs_writel'
> drivers/mmc/host/sdhci-of-esdhc.o:(.opd+0x48): first defined here
> drivers/mmc/host/sdhci-of-hlwd.o: In function `sdhci_pltfm_unregister':
> (.opd+0xf0): multiple definition of `sdhci_pltfm_unregister'
> drivers/mmc/host/sdhci-of-esdhc.o:(.opd+0xf0): first defined here
> drivers/mmc/host/sdhci-of-hlwd.o: In function `sdhci_be32bs_writew':
> (.opd+0x60): multiple definition of `sdhci_be32bs_writew'
> drivers/mmc/host/sdhci-of-esdhc.o:(.opd+0x60): first defined here
> drivers/mmc/host/sdhci-of-hlwd.o: In function `.sdhci_pltfm_resume':
> (.text+0xc70): multiple definition of `.sdhci_pltfm_resume'
> drivers/mmc/host/sdhci-of-esdhc.o:(.text+0xc70): first defined here
> drivers/mmc/host/sdhci-of-hlwd.o: In function `.sdhci_be32bs_writeb':
> (.text+0x2ac): multiple definition of `.sdhci_be32bs_writeb'
> drivers/mmc/host/sdhci-of-esdhc.o:(.text+0x2ac): first defined here
> drivers/mmc/host/sdhci-of-hlwd.o: In function `.sdhci_pltfm_suspend':
> (.text+0xc04): multiple definition of `.sdhci_pltfm_suspend'
> drivers/mmc/host/sdhci-of-esdhc.o:(.text+0xc04): first defined here
> drivers/mmc/host/sdhci-of-hlwd.o: In function `.sdhci_pltfm_register':
> (.text+0x9c0): multiple definition of `.sdhci_pltfm_register'
> drivers/mmc/host/sdhci-of-esdhc.o:(.text+0x9c0): first defined here
> drivers/mmc/host/sdhci-of-hlwd.o: In function `.sdhci_be32bs_readl':
> (.text+0x0): multiple definition of `.sdhci_be32bs_readl'
> drivers/mmc/host/sdhci-of-esdhc.o:(.text+0x0): first defined here
> drivers/mmc/host/sdhci-of-hlwd.o: In function `sdhci_be32bs_writeb':
> (.opd+0x78): multiple definition of `sdhci_be32bs_writeb'
> drivers/mmc/host/sdhci-of-esdhc.o:(.opd+0x78): first defined here
> drivers/mmc/host/sdhci-of-hlwd.o: In function `sdhci_pltfm_suspend':
> (.opd+0x108): multiple definition of `sdhci_pltfm_suspend'
> drivers/mmc/host/sdhci-of-esdhc.o:(.opd+0x108): first defined here
> drivers/mmc/host/sdhci-of-hlwd.o: In function `sdhci_get_of_property':
> (.opd+0x90): multiple definition of `sdhci_get_of_property'
> drivers/mmc/host/sdhci-of-esdhc.o:(.opd+0x90): first defined here
> drivers/mmc/host/sdhci-of-hlwd.o: In function `sdhci_pltfm_init':
> (.opd+0xa8): multiple definition of `sdhci_pltfm_init'
> drivers/mmc/host/sdhci-of-esdhc.o:(.opd+0xa8): first defined here
> drivers/mmc/host/sdhci-of-hlwd.o: In function `sdhci_be32bs_readb':
> (.opd+0x30): multiple definition of `sdhci_be32bs_readb'
> drivers/mmc/host/sdhci-of-esdhc.o:(.opd+0x30): first defined here
> 
> Presumably caused by commit e2d0d7dc5542 ("mmc: sdhci: make sdhci-of
> device drivers self registered").
> 
I did build test for powerpc in the first a few rounds posts, but
forgot the in the last ones.  I will fix this soon.  Sorry for this.

-- 
Regards,
Shawn

linux-next: build failure after merge of the final tree (mmc tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/mmc/host/sdhci-of-esdhc.c:143:2: error: unknown field 'platform_suspend' specified in initializer
drivers/mmc/host/sdhci-of-esdhc.c:143:2: warning: initialization from incompatible pointer type [enabled by default]
drivers/mmc/host/sdhci-of-esdhc.c:143:2: warning: (near initialization for 'sdhci_esdhc_ops.get_timeout_clock') [enabled by default]
drivers/mmc/host/sdhci-of-esdhc.c:144:2: error: unknown field 'platform_resume' specified in initializer
drivers/mmc/host/sdhci-of-esdhc.c:144:2: warning: initialization from incompatible pointer type [enabled by default]
drivers/mmc/host/sdhci-of-esdhc.c:144:2: warning: (near initialization for 'sdhci_esdhc_ops.platform_8bit_width') [enabled by default]

Caused by commit 4f6eeb41eee9 ("mmc: esdhc: Implement power management
for ESDHC").  I can't see how that was ever even build tested ..

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

RE: linux-next: build failure after merge of the final tree (mmc tree related)

[Huang Changming-R66093]

Hi, 
Chris' patch which defined the "platform_suspend" is needed.

> -----Original Message-----
> From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
> Sent: Monday, February 06, 2012 12:39 PM
> To: Chris Ball
> Cc: linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Huang
> Changming-R66093; Jiang Yutang-B14898; Anton Vorontsov
> Subject: linux-next: build failure after merge of the final tree (mmc
> tree related)
> 
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/mmc/host/sdhci-of-esdhc.c:143:2: error: unknown field
> 'platform_suspend' specified in initializer
> drivers/mmc/host/sdhci-of-esdhc.c:143:2: warning: initialization from
> incompatible pointer type [enabled by default]
> drivers/mmc/host/sdhci-of-esdhc.c:143:2: warning: (near initialization
> for 'sdhci_esdhc_ops.get_timeout_clock') [enabled by default]
> drivers/mmc/host/sdhci-of-esdhc.c:144:2: error: unknown field
> 'platform_resume' specified in initializer
> drivers/mmc/host/sdhci-of-esdhc.c:144:2: warning: initialization from
> incompatible pointer type [enabled by default]
> drivers/mmc/host/sdhci-of-esdhc.c:144:2: warning: (near initialization
> for 'sdhci_esdhc_ops.platform_8bit_width') [enabled by default]
> 
> Caused by commit 4f6eeb41eee9 ("mmc: esdhc: Implement power management
> for ESDHC").  I can't see how that was ever even build tested ..
> 
> I have reverted that commit for today.
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au