From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
To: Eric Paris <eparis@redhat.com>
Cc: sfr@canb.auug.org.au, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the fsnotify tree
Date: Wed, 10 Nov 2010 18:14:05 +0100 [thread overview]
Message-ID: <20101110171405.GA4485@lsanfilippo.unix.rd.tt.avira.com> (raw)
In-Reply-To: <1289403143.3083.54.camel@localhost.localdomain>
On Wed, Nov 10, 2010 at 10:32:23AM -0500, Eric Paris wrote:
> On Wed, 2010-11-10 at 12:53 +1100, Stephen Rothwell wrote:
> > Hi Eric,
> >
> > After merging the fsnotify tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> >
> > fs/notify/mark.c: In function 'fsnotify_add_mark':
> > fs/notify/mark.c:230: error: 'struct fsnotify_group' has no member named 'fanotify_data'
> >
> > Caused by commit 0ed64ab6b338e4269c9f25de83781619ecd624f1 ("fsnotify:
> > code and error path cleanup in fsnotify_add_mark"). This build has
> > CONFIG_FANOTIFY not set.
> >
> > I have used the fsnotify tree from next-20101109 for today.
>
> I wasn't actually that commit it was:
>
> 5876b30fc2c91d67386f91da62b14f159d7bb41f ("fanotify: Do check against
> max_marks and increase number of group marks atomically")
>
> Lino, I knew there was a reason I was happy with the small race. Would
> you like to take another stab or should I just revert?
>
> -Eric
>
Damn, sorry for that.
Please revert it Eric. But we should somehow avoid this race. What about
making max_marks a generic groups attribute?
Lino
next prev parent reply other threads:[~2010-11-10 17:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 1:53 linux-next: build failure after merge of the fsnotify tree Stephen Rothwell
2010-11-10 15:32 ` Eric Paris
2010-11-10 17:14 ` Lino Sanfilippo [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-12-19 0:55 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101110171405.GA4485@lsanfilippo.unix.rd.tt.avira.com \
--to=linosanfilippo@gmx.de \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).