* Re: [PATCH] quota: Use %pV and __attribute__((format (printf in __quota_error and fix fallout
[not found] ` <20101124125029.GO6113@quack.suse.cz>
@ 2010-11-24 15:01 ` Joe Perches
2010-11-24 16:30 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Joe Perches @ 2010-11-24 15:01 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-kernel, linux-next, Stephen Rothwell
On Wed, 2010-11-24 at 13:50 +0100, Jan Kara wrote:
> On Tue 23-11-10 18:49:54, Joe Perches wrote:
> > Use %pV in __quota_error so a single printk can not be
> > interleaved with other logging messages.
> > Add __attribute__((format (printf, 3, 4))) so format
> > and arguments can be verified by compiler.
> > Make sure printk formats and arguments match.
> >
> > Block # needed a pointer dereference.
> I already had a similar patch from you in my tree. So I've replaced it.
Perhaps you can get your tree into linux-next.
I believe you only have to send a request to
Stephen Rothwell (cc'd).
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] quota: Use %pV and __attribute__((format (printf in __quota_error and fix fallout
2010-11-24 15:01 ` [PATCH] quota: Use %pV and __attribute__((format (printf in __quota_error and fix fallout Joe Perches
@ 2010-11-24 16:30 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2010-11-24 16:30 UTC (permalink / raw)
To: Joe Perches; +Cc: Jan Kara, linux-kernel, linux-next, Stephen Rothwell
On Wed 24-11-10 07:01:17, Joe Perches wrote:
> On Wed, 2010-11-24 at 13:50 +0100, Jan Kara wrote:
> > On Tue 23-11-10 18:49:54, Joe Perches wrote:
> > > Use %pV in __quota_error so a single printk can not be
> > > interleaved with other logging messages.
> > > Add __attribute__((format (printf, 3, 4))) so format
> > > and arguments can be verified by compiler.
> > > Make sure printk formats and arguments match.
> > >
> > > Block # needed a pointer dereference.
> > I already had a similar patch from you in my tree. So I've replaced it.
>
> Perhaps you can get your tree into linux-next.
>
> I believe you only have to send a request to
> Stephen Rothwell (cc'd).
It's there but I didn't push the for_next branch. I'll do that as soon
as I'm able to finish some testing on it...
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-24 16:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1290566994.11971.26.camel@Joe-Laptop>
[not found] ` <20101124125029.GO6113@quack.suse.cz>
2010-11-24 15:01 ` [PATCH] quota: Use %pV and __attribute__((format (printf in __quota_error and fix fallout Joe Perches
2010-11-24 16:30 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).