From: Andres Salomon <dilinger@queued.net>
To: Samuel Ortiz <sameo@linux.intel.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cs5535-mfd: fix warning on x86-64
Date: Tue, 7 Dec 2010 10:38:06 -0800 [thread overview]
Message-ID: <20101207103806.74cc9f48@queued.net> (raw)
In-Reply-To: <20101130100137.GA11125@sortiz-mobl>
On Tue, 30 Nov 2010 11:01:38 +0100
Samuel Ortiz <sameo@linux.intel.com> wrote:
> Hi Andres,
>
> On Mon, Nov 29, 2010 at 08:44:10PM -0800, Andres Salomon wrote:
> > On Mon, 29 Nov 2010 11:52:57 +1100
> > Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > > Hi Samuel,
> > >
> > > After merging the mfd tree, today's linux-next build (x86_64
> > > allmodconfig) produced this warning:
> > >
> > > drivers/mfd/cs5535-mfd.c: In function 'cs5535_mfd_probe':
> > > drivers/mfd/cs5535-mfd.c:106: warning: format '%d' expects type
> > > 'int', but argument 3 has type 'long unsigned int'
> > >
> >
> > Ick, ARRAY_SIZE is unsigned int on x86, unsigned long on x86-64.
> > The patch below fixes this.
> >
> >
> >
> >
> > From: Andres Salomon <dilinger@queued.net>
> >
> > ARRAY_SIZE() returns unsigned long on x86-64 (rather than unsigned
> > int); cast it to the desired type to shut gcc up.
> Patch applied, many thanks.
> I'll look at your subdevices patches by the end of this week.
>
Did you get the chance to look at them? Also, note that there's an
updated patch for the cs5535-mfd warnings (v2, acked by Randy).
next prev parent reply other threads:[~2010-12-07 18:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 0:52 linux-next: build warning after merge of the mfd tree Stephen Rothwell
2010-11-30 4:44 ` [PATCH] cs5535-mfd: fix warning on x86-64 Andres Salomon
2010-11-30 10:01 ` Samuel Ortiz
2010-12-07 18:38 ` Andres Salomon [this message]
2010-12-09 11:49 ` Samuel Ortiz
2010-11-30 18:22 ` Randy Dunlap
2010-11-30 21:44 ` Andres Salomon
2010-11-30 21:54 ` [PATCH] cs5535-mfd: fix warning on x86-64 (v2) Andres Salomon
2010-11-30 22:36 ` Randy Dunlap
2010-11-30 10:02 ` linux-next: build warning after merge of the mfd tree Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101207103806.74cc9f48@queued.net \
--to=dilinger@queued.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).