From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andres Salomon Subject: Re: [PATCH] cs5535-mfd: fix warning on x86-64 Date: Tue, 7 Dec 2010 10:38:06 -0800 Message-ID: <20101207103806.74cc9f48@queued.net> References: <20101129115257.9a78ad14.sfr@canb.auug.org.au> <20101129204410.339805ef@queued.net> <20101130100137.GA11125@sortiz-mobl> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from LUNGE.MIT.EDU ([18.54.1.69]:45513 "EHLO lunge.queued.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752283Ab0LGSiK (ORCPT ); Tue, 7 Dec 2010 13:38:10 -0500 In-Reply-To: <20101130100137.GA11125@sortiz-mobl> Sender: linux-next-owner@vger.kernel.org List-ID: To: Samuel Ortiz Cc: Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, 30 Nov 2010 11:01:38 +0100 Samuel Ortiz wrote: > Hi Andres, > > On Mon, Nov 29, 2010 at 08:44:10PM -0800, Andres Salomon wrote: > > On Mon, 29 Nov 2010 11:52:57 +1100 > > Stephen Rothwell wrote: > > > > > Hi Samuel, > > > > > > After merging the mfd tree, today's linux-next build (x86_64 > > > allmodconfig) produced this warning: > > > > > > drivers/mfd/cs5535-mfd.c: In function 'cs5535_mfd_probe': > > > drivers/mfd/cs5535-mfd.c:106: warning: format '%d' expects type > > > 'int', but argument 3 has type 'long unsigned int' > > > > > > > Ick, ARRAY_SIZE is unsigned int on x86, unsigned long on x86-64. > > The patch below fixes this. > > > > > > > > > > From: Andres Salomon > > > > ARRAY_SIZE() returns unsigned long on x86-64 (rather than unsigned > > int); cast it to the desired type to shut gcc up. > Patch applied, many thanks. > I'll look at your subdevices patches by the end of this week. > Did you get the chance to look at them? Also, note that there's an updated patch for the cs5535-mfd warnings (v2, acked by Randy).