* [PATCH] ASoC: tpa6130a2: Fix compiler warning
@ 2010-12-28 9:16 Peter Ujfalusi
2010-12-28 11:37 ` Mark Brown
2011-01-12 0:53 ` Liam Girdwood
0 siblings, 2 replies; 3+ messages in thread
From: Peter Ujfalusi @ 2010-12-28 9:16 UTC (permalink / raw)
To: alsa-devel
Cc: Stephen Rothwell, Mark Brown, linux-next, linux-kernel,
Liam Girdwood
sound/soc/codecs/tpa6130a2.c: In function 'tpa6130a2_add_controls':
sound/soc/codecs/tpa6130a2.c:342: warning: unused variable 'dapm'
Introduced by commit 39646871a47fd8808c08de0ce7d7ca8393af2805 ("ASoC:
tpa6130a2: Replace DAPM code with direct interface").
The DAPM code has been removed from the driver, but the
dapm struct remained.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
---
sound/soc/codecs/tpa6130a2.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/tpa6130a2.c b/sound/soc/codecs/tpa6130a2.c
index 0a99f31..1f1ac81 100644
--- a/sound/soc/codecs/tpa6130a2.c
+++ b/sound/soc/codecs/tpa6130a2.c
@@ -339,7 +339,6 @@ EXPORT_SYMBOL_GPL(tpa6130a2_stereo_enable);
int tpa6130a2_add_controls(struct snd_soc_codec *codec)
{
struct tpa6130a2_data *data;
- struct snd_soc_dapm_context *dapm = &codec->dapm;
if (tpa6130a2_client == NULL)
return -ENODEV;
--
1.7.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: tpa6130a2: Fix compiler warning
2010-12-28 9:16 [PATCH] ASoC: tpa6130a2: Fix compiler warning Peter Ujfalusi
@ 2010-12-28 11:37 ` Mark Brown
2011-01-12 0:53 ` Liam Girdwood
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2010-12-28 11:37 UTC (permalink / raw)
To: Peter Ujfalusi
Cc: alsa-devel, Liam Girdwood, Stephen Rothwell, linux-next,
linux-kernel
On Tue, Dec 28, 2010 at 11:16:19AM +0200, Peter Ujfalusi wrote:
> sound/soc/codecs/tpa6130a2.c: In function 'tpa6130a2_add_controls':
> sound/soc/codecs/tpa6130a2.c:342: warning: unused variable 'dapm'
>
> Introduced by commit 39646871a47fd8808c08de0ce7d7ca8393af2805 ("ASoC:
> tpa6130a2: Replace DAPM code with direct interface").
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: tpa6130a2: Fix compiler warning
2010-12-28 9:16 [PATCH] ASoC: tpa6130a2: Fix compiler warning Peter Ujfalusi
2010-12-28 11:37 ` Mark Brown
@ 2011-01-12 0:53 ` Liam Girdwood
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2011-01-12 0:53 UTC (permalink / raw)
To: Peter Ujfalusi
Cc: Stephen Rothwell, alsa-devel, Mark Brown, linux-next,
linux-kernel
On Tue, 2010-12-28 at 11:16 +0200, Peter Ujfalusi wrote:
> sound/soc/codecs/tpa6130a2.c: In function 'tpa6130a2_add_controls':
> sound/soc/codecs/tpa6130a2.c:342: warning: unused variable 'dapm'
>
> Introduced by commit 39646871a47fd8808c08de0ce7d7ca8393af2805 ("ASoC:
> tpa6130a2: Replace DAPM code with direct interface").
>
> The DAPM code has been removed from the driver, but the
> dapm struct remained.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> ---
> sound/soc/codecs/tpa6130a2.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/codecs/tpa6130a2.c b/sound/soc/codecs/tpa6130a2.c
> index 0a99f31..1f1ac81 100644
> --- a/sound/soc/codecs/tpa6130a2.c
> +++ b/sound/soc/codecs/tpa6130a2.c
> @@ -339,7 +339,6 @@ EXPORT_SYMBOL_GPL(tpa6130a2_stereo_enable);
> int tpa6130a2_add_controls(struct snd_soc_codec *codec)
> {
> struct tpa6130a2_data *data;
> - struct snd_soc_dapm_context *dapm = &codec->dapm;
>
> if (tpa6130a2_client == NULL)
> return -ENODEV;
Applied.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-01-12 0:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-28 9:16 [PATCH] ASoC: tpa6130a2: Fix compiler warning Peter Ujfalusi
2010-12-28 11:37 ` Mark Brown
2011-01-12 0:53 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).