From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: linux-next: Tree for March 1 (staging/winbond) Date: Tue, 1 Mar 2011 11:39:30 -0800 Message-ID: <20110301113930.69d7d992.randy.dunlap@oracle.com> References: <20110301181119.f1c7a9c3.sfr@canb.auug.org.au> <20110301104924.071044ef.randy.dunlap@oracle.com> <20110301111922.69b0d8c1.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from rcsinet10.oracle.com ([148.87.113.121]:22642 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757234Ab1CATjq convert rfc822-to-8bit (ORCPT ); Tue, 1 Mar 2011 14:39:46 -0500 In-Reply-To: Sender: linux-next-owner@vger.kernel.org List-ID: To: Pekka Enberg Cc: Stephen Rothwell , linux-next@vger.kernel.org, LKML , gregkh@suse.de On Tue, 1 Mar 2011 21:35:59 +0200 Pekka Enberg wrote: > On Tue, Mar 1, 2011 at 9:19 PM, Randy Dunlap wrote: > > On Tue, 1 Mar 2011 21:10:23 +0200 Pekka Enberg wrote: > > > >> On Tue, Mar 1, 2011 at 8:49 PM, Randy Dunlap wrote: > >> > On Tue, 1 Mar 2011 18:11:19 +1100 Stephen Rothwell wrote: > >> > > >> >> Hi all, > >> >> > >> >> Changes since 20110228: > >> > > >> > > >> > commit ddee7e28e7d5e4ba2b8537c6a59b035745c250bb > >> > Author: Pekka Enberg > >> > Date: =A0 Sun Nov 28 23:00:01 2010 +0200 > >> > =A0 =A0Staging: w35und: Remove empty sysdef.h header > >> > > >> > > >> > This header should not have been empty, since in > >> > > >> > commit 412dc7f368bf10a8049a8a4c41abbfd0108742e7 > >> > Author: Randy Dunlap > >> > Date: =A0 Fri Nov 19 09:30:18 2010 -0800 > >> > =A0 =A0staging: fix winbond build, needs delay.h > >> > > >> > I added delay.h to it. =A0And now we have the same build > >> > errors that I fixed last November: > >> > > >> > drivers/staging/winbond/phy_calibration.c:986: error: implicit d= eclaration of function 'msleep' > >> > drivers/staging/winbond/phy_calibration.c:1555: error: implicit = declaration of function 'udelay' > >> > drivers/staging/winbond/reg.c:893: error: implicit declaration o= f function 'msleep' > >> > drivers/staging/winbond/reg.c:1169: error: implicit declaration = of function 'udelay' > >> > >> Strange. I didn't see the problem. We should add delay.h to > >> phy_calibration.c and reg.c instead. Care to make a patch? > >> -- > > > > No thanks, I'll let the staging people do that. >=20 > Hmm, commit cecf826df8648c843ea8db63b1f82c154a74db36 ("staging: > winbond: needs for msleep and friends") should fix it= =2E > Isn't it in linux-next yet? I'll have to let GregKH answer that. Where is the commit ID from? --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your cod= e ***